Closed
Bug 1086939
Opened 10 years ago
Closed 10 years ago
Locale suggestion - Error: accept is null
Categories
(Webmaker Graveyard :: webmaker.org, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: cade, Assigned: cade)
References
Details
Attachments
(1 file)
https://github.com/mozilla/webmaker.org/blob/ada40deb85ef9f6c4aee46304f8d24b5d6c7c9b0/public/js/angular/controllers.js#L559-L563
That code throws for me in Firefox 35.
It's breaking the instant login feature of the new login system.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → cade
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•10 years ago
|
||
The race condition where the elements don't exist when the code runs can be avoided by setting up the event listeners with the ng-click directive.
Attachment #8509503 -
Flags: review?(kate)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8509503 [details] [review]
https://github.com/mozilla/webmaker.org/pull/1005
Looks good to me
Attachment #8509503 -
Flags: review?(kate) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Comment 4•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/webmaker.org
https://github.com/mozilla/webmaker.org/commit/afe8002af9831fabe4df731fa6a5fe0f3d51c3f4
Bug 1086939 - missing semicolons in locale banner controller
You need to log in
before you can comment on or make changes to this bug.
Description
•