Closed Bug 1086987 Opened 5 years ago Closed 5 years ago

Require fanotify support on KK gonk

Categories

(Firefox OS Graveyard :: General, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S8 (7Nov)

People

(Reporter: mwu, Assigned: mwu)

References

Details

Attachments

(7 files, 1 obsolete file)

fanotify support should be required. It's easy to turn on and easy to miss if disabled. We may have to turn it on the emulator kernels.
Is there a way to test for it and like fatally assert on b2g startup if it's missing?
(In reply to ben turner [:bent] (use the needinfo? flag!) from comment #1)
> Is there a way to test for it and like fatally assert on b2g startup if it's
> missing?

Yes, we just display a message right now instead of asserting at http://mxr.mozilla.org/mozilla-central/source/hal/gonk/GonkDiskSpaceWatcher.cpp#171
I think we can start with KK only since all the AOSP port kernels need to be rebuilt and I'd like to reduce the number of kernels I need to rebuild.
Attachment #8509058 - Flags: review?(dhylands)
Comment on attachment 8509058 [details] [diff] [review]
MOZ_CRASH if there is no fanotify support

Review of attachment 8509058 [details] [diff] [review]:
-----------------------------------------------------------------

Seems reasonable to me.
Attachment #8509058 - Flags: review?(dhylands) → review+
Attachment #8512165 - Flags: review?(jld)
Attachment #8512166 - Flags: review?(jld)
Attachment #8512169 - Flags: review?(jld)
Attachment #8512169 - Attachment is obsolete: true
Attachment #8512169 - Flags: review?(jld)
Attachment #8512173 - Flags: review?(jld)
Attachment #8512165 - Flags: review?(jld) → review+
Attachment #8512166 - Flags: review?(jld) → review+
Attachment #8512173 - Flags: review?(jld) → review+
Attachment #8512263 - Flags: review?(jld)
Attachment #8512264 - Flags: review?(jld)
Attachment #8512265 - Flags: review?(jld)
Attachment #8512263 - Flags: review?(jld) → review+
Attachment #8512264 - Flags: review?(jld) → review+
Attachment #8512265 - Flags: review?(jld) → review+
https://hg.mozilla.org/mozilla-central/rev/74a74122337f
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S8 (7Nov)
You need to log in before you can comment on or make changes to this bug.