1086987 - Require fanotify support on KK gonk

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Michael Wu [:mwu]]

fanotify support should be required. It's easy to turn on and easy to miss if disabled. We may have to turn it on the emulator kernels.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Is there a way to test for it and like fatally assert on b2g startup if it's missing?

Comment 2

[[:fabrice] Fabrice Desré]

(In reply to ben turner [:bent] (use the needinfo? flag!) from comment #1)
> Is there a way to test for it and like fatally assert on b2g startup if it's
> missing?

Yes, we just display a message right now instead of asserting at http://mxr.mozilla.org/mozilla-central/source/hal/gonk/GonkDiskSpaceWatcher.cpp#171

Comment 3

[Michael Wu [:mwu]]

Attachment: MOZ_CRASH if there is no fanotify support

I think we can start with KK only since all the AOSP port kernels need to be rebuilt and I'd like to reduce the number of kernels I need to rebuild.

Comment 4

[Dave Hylands [:dhylands]]

Comment on attachment 8509058 [details] [diff] [review]
MOZ_CRASH if there is no fanotify support

Review of attachment 8509058 [details] [diff] [review]:
-----------------------------------------------------------------

Seems reasonable to me.

Comment 5

[Michael Wu [:mwu]]

Attachment: Enable CONFIG_FANOTIFY in hammerhead_defconfig

Comment 6

[Michael Wu [:mwu]]

Attachment: Enable CONFIG_FANOTIFY in mako_defconfig

Comment 7

[Michael Wu [:mwu]]

Attachment: https://github.com/mozilla-b2g/kernel_goldfish/pull/14

Comment 8

[Michael Wu [:mwu]]

Attachment: Enable CONFIG_FANOTIFY in goldfish_defconfig

Comment 9

[Michael Wu [:mwu]]

Kernel configs updates merged:

https://github.com/mozilla-b2g/codeaurora_kernel_msm/commit/b02b98ad1ae04169a0b7c9a57565126f3b3b918e
https://github.com/mozilla-b2g/codeaurora_kernel_msm/commit/971967ea8df857c78018c8792c230385f73338b4
https://github.com/mozilla-b2g/kernel_goldfish/commit/f5af86783ee925746e4b073948605b7f5ffd9fbd

Comment 10

[Michael Wu [:mwu]]

Attachment: Update hammerhead kernel for CONFIG_FANOTIFY

Comment 11

[Michael Wu [:mwu]]

Attachment: Update mako kernel for CONFIG_FANOTIFY

Comment 12

[Michael Wu [:mwu]]

Attachment: Update goldfish kernel for CONFIG_FANOTIFY

Comment 13

[Michael Wu [:mwu]]

Updated kernels merged.

https://github.com/mozilla-b2g/device_lge_hammerhead-kernel/commit/44b3af8ef361898da6943176413e9bce299444a3
https://github.com/mozilla-b2g/device_lge_mako-kernel/commit/a49f2c34bc50a07b02f010a53d80477542209a81
https://github.com/mozilla-b2g/platform_prebuilts_qemu-kernel/commit/c24c8871173bf6aedcf236cab075edf092a7015c

Comment 14

[Michael Wu [:mwu]]

https://hg.mozilla.org/integration/b2g-inbound/rev/74a74122337f

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/74a74122337f