Enable crash handling in search activity

RESOLVED FIXED in Firefox 36

Status

()

Firefox for Android
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jchen, Assigned: jchen)

Tracking

Trunk
Firefox 36
Points:
---

Firefox Tracking Flags

(firefox35 wontfix, firefox36 fixed, fennec35+)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
We should turn on crash handling in search activity, which can run independently of Gecko.
(Assignee)

Comment 1

3 years ago
Created attachment 8509045 [details] [diff] [review]
Enable crash handling in search activity (v1)

SearchActivity already has a dependency on GeckoAppShell through Telemetry. Because GeckoAppShell automatically registers a crash handler when it's initialized, we can just rely on it to handle search activity crashes.

This patch simply adds a stub method in GeckoAppShell, so that we explicitly load the class on search activity creation (instead of implicitly loading it through Telemetry).
Attachment #8509045 - Flags: review?(margaret.leibovic)

Comment 2

3 years ago
Comment on attachment 8509045 [details] [diff] [review]
Enable crash handling in search activity (v1)

Review of attachment 8509045 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds reasonable to me.
Attachment #8509045 - Flags: review?(margaret.leibovic) → review+
https://hg.mozilla.org/mozilla-central/rev/c16d0c10a89b
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36

Comment 5

3 years ago
Let's uplift this to 35.
tracking-fennec: --- → 35+

Comment 6

3 years ago
Comment on attachment 8509045 [details] [diff] [review]
Enable crash handling in search activity (v1)

Approval Request Comment
[Feature/regressing bug #]: search activity
[User impact if declined]: we might miss crash reports from search activity
[Describe test coverage new/current, TBPL]: no automated tests, baked on m-c
[Risks and why]: low-risk, small change to make sure crash handled is initialized when search activity is created
[String/UUID change made/needed]: none
Attachment #8509045 - Flags: approval-mozilla-aurora?
Attachment #8509045 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/63bc9380161
status-firefox35: --- → fixed
status-firefox36: --- → fixed
Backed out for bustage. I'm guessing this needs bug 1043457 to be uplifted as well?
https://hg.mozilla.org/releases/mozilla-aurora/rev/dd2f144cdf44

https://treeherder.mozilla.org/ui/logviewer.html#?job_id=398913&repo=mozilla-aurora
status-firefox35: fixed → affected

Comment 9

3 years ago
(In reply to [Away 18-Nov to 23-Nov] Ryan VanderMeulen [:RyanVM UTC-5] from comment #8)
> Backed out for bustage. I'm guessing this needs bug 1043457 to be uplifted
> as well?
> https://hg.mozilla.org/releases/mozilla-aurora/rev/dd2f144cdf44
> 
> https://treeherder.mozilla.org/ui/logviewer.html#?job_id=398913&repo=mozilla-
> aurora

Oh, I'm sorry, I should have looked at the dependencies more closely. If the crash handling changes aren't in 35, I don't think we need to uplift this change as well. I just assumed that this should be uplifted as part of the search activity feature, which is new in 35.
Setting Fx35 to wontfix per comment 9. Feel free to change that back if there's disagreement.
status-firefox35: affected → wontfix
Attachment #8509045 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.