1086994 - Enable crash handling in search activity

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

We should turn on crash handling in search activity, which can run independently of Gecko.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Enable crash handling in search activity (v1)

SearchActivity already has a dependency on GeckoAppShell through Telemetry. Because GeckoAppShell automatically registers a crash handler when it's initialized, we can just rely on it to handle search activity crashes.

This patch simply adds a stub method in GeckoAppShell, so that we explicitly load the class on search activity creation (instead of implicitly loading it through Telemetry).

Comment 2

[:Margaret Leibovic]

Comment on attachment 8509045 [details] [diff] [review]
Enable crash handling in search activity (v1)

Review of attachment 8509045 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds reasonable to me.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

https://hg.mozilla.org/integration/fx-team/rev/c16d0c10a89b

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c16d0c10a89b

Comment 5

[:Margaret Leibovic]

Let's uplift this to 35.

Comment 6

[:Margaret Leibovic]

Comment on attachment 8509045 [details] [diff] [review]
Enable crash handling in search activity (v1)

Approval Request Comment
[Feature/regressing bug #]: search activity
[User impact if declined]: we might miss crash reports from search activity
[Describe test coverage new/current, TBPL]: no automated tests, baked on m-c
[Risks and why]: low-risk, small change to make sure crash handled is initialized when search activity is created
[String/UUID change made/needed]: none

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/63bc9380161

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Backed out for bustage. I'm guessing this needs bug 1043457 to be uplifted as well?
https://hg.mozilla.org/releases/mozilla-aurora/rev/dd2f144cdf44

https://treeherder.mozilla.org/ui/logviewer.html#?job_id=398913&repo=mozilla-aurora

Comment 9

[:Margaret Leibovic]

(In reply to [Away 18-Nov to 23-Nov] Ryan VanderMeulen [:RyanVM UTC-5] from comment #8)
> Backed out for bustage. I'm guessing this needs bug 1043457 to be uplifted
> as well?
> https://hg.mozilla.org/releases/mozilla-aurora/rev/dd2f144cdf44
> 
> https://treeherder.mozilla.org/ui/logviewer.html#?job_id=398913&repo=mozilla-
> aurora

Oh, I'm sorry, I should have looked at the dependencies more closely. If the crash handling changes aren't in 35, I don't think we need to uplift this change as well. I just assumed that this should be uplifted as part of the search activity feature, which is new in 35.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Setting Fx35 to wontfix per comment 9. Feel free to change that back if there's disagreement.