Closed Bug 1087029 Opened 10 years ago Closed 9 years ago

Convert SortedDict to OrderedDict

Categories

(Marketplace Graveyard :: Code Quality, defect, P4)

Product:
Marketplace Graveyard
Component:
Code Quality
Version:
Avenir
Platform:
x86
macOS
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2015-06-30

People

(Reporter: robhudson, Assigned: robhudson)

References

Details

(Whiteboard: [repoman][qa-]) 

https://docs.djangoproject.com/en/dev/releases/1.7/#django-utils-datastructures-sorteddict

As OrderedDict was added to the standard library in Python 2.7, SortedDict is no longer needed and has been deprecated.
Priority: -- → P4
Whiteboard: [repoman]
Depends on: 785137
I set bug 1010605 as dupe even though it's not exactly the same thing, just because it's likely the 2 tasks will be done together. So we should:
- Move all SortedDict to OrderedDict (from python 2.7 standard library)
- Remove all instances of ordereddict.OrderedDict, including line in requirements.txt
The line in requirements.txt might need to stay. orderreddict is required by kombu, which is required by celery. When tackling this bug, consider whether the version of kombu we use needs orderreddict to work or not (they might want to keep python 2.6 compatibility).
Assignee: nobody → robhudson.mozbugs
Blocks: 1157970
https://github.com/mozilla/zamboni/commit/3c5c6cb8efa3548138f5eaad63d08e1bcac41fee
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [repoman] → [repoman][qa-]
Target Milestone: --- → 2015-06-30
You need to log in before you can comment on or make changes to this bug.