Closed Bug 1087112 Opened 9 years ago Closed 9 years ago

Intermittent browser_586068-reload.js | This test exceeded the timeout threshold. It should be rewritten or split up.

Categories

(Firefox :: Session Restore, defect)

Product:
Firefox
Component:
Session Restore
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal
Points:
3

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 36
Iteration:
36.3
Tracking Flags:
Tracking Status
firefox34 --- unaffected
firefox35 --- fixed
firefox36 --- fixed
firefox-esr31 --- unaffected

People

(Reporter: KWierso, Assigned: ttaubert)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

0001-Bug-1087112-Fix-intermittent-issues-with-browser_586.patch
6.78 KB, patch
smacleod
: review+
Details | Diff | Splinter Review 
https://treeherder.mozilla.org/ui/logviewer.html#?job_id=3183501&repo=mozilla-inbound
builder 	Ubuntu VM 12.04 mozilla-inbound debug test mochitest-browser-chrome-1
buildid 	20141021120445
builduid 	3d8e1b2abac642939b171837858cd960
results 	warnings (1)
revision 	00997b2b5a16
slave 	tst-linux32-spot-142
starttime 	Tue Oct 21 2014 13:11:43 GMT-0700 (Pacific Standard Time)



14:14:02 INFO - --DOMWINDOW == 243 (0x71f05200) [pid = 1860] [serial = 7712] [outer = (nil)] [url = http://example.org/#10]
14:14:02 INFO - --DOMWINDOW == 242 (0x71f06750) [pid = 1860] [serial = 7715] [outer = (nil)] [url = http://example.org/#13]
14:14:02 INFO - --DOMWINDOW == 241 (0x71f06940) [pid = 1860] [serial = 7716] [outer = (nil)] [url = http://example.org/#14]
14:14:02 INFO - --DOMWINDOW == 240 (0x71f04a40) [pid = 1860] [serial = 7709] [outer = (nil)] [url = http://example.org/#7]
14:14:02 INFO - 1484 INFO checking window state
14:14:02 INFO - 1485 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 1 - browser loaded correct url
14:14:02 INFO - 1486 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 1 - correct tab was restored
14:14:02 INFO - 1487 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 2 - browser loaded correct url
14:14:02 INFO - 1488 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 2 - correct tab was restored
14:14:02 INFO - 1489 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 3 - browser loaded correct url
14:14:02 INFO - 1490 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 3 - correct tab was restored
14:14:02 INFO - 1491 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 4 - browser loaded correct url
14:14:02 INFO - 1492 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 4 - correct tab was restored
14:14:02 INFO - 1493 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 5 - browser loaded correct url
14:14:02 INFO - 1494 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 5 - correct tab was restored
14:14:02 INFO - 1495 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 6 - browser loaded correct url
14:14:02 INFO - 1496 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 6 - correct tab was restored
14:14:02 INFO - 1497 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 7 - browser loaded correct url
14:14:02 INFO - 1498 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 7 - correct tab was restored
14:14:02 INFO - 1499 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 8 - browser loaded correct url
14:14:02 INFO - 1500 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 8 - correct tab was restored
14:14:02 INFO - 1501 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 9 - browser loaded correct url
14:14:02 INFO - 1502 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 9 - correct tab was restored
14:14:02 INFO - 1503 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 10 - browser loaded correct url
14:14:02 INFO - 1504 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 10 - correct tab was restored
14:14:02 INFO - 1505 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 11 - browser loaded correct url
14:14:02 INFO - 1506 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 11 - correct tab was restored
14:14:02 INFO - 1507 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 12 - browser loaded correct url
14:14:02 INFO - 1508 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 12 - correct tab was restored
14:14:02 INFO - 1509 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 13 - browser loaded correct url
14:14:02 INFO - 1510 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 13 - correct tab was restored
14:14:02 INFO - 1511 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 14 - browser loaded correct url
14:14:02 INFO - 1512 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 14 - correct tab was restored
14:14:02 INFO - 1513 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 15 - browser loaded correct url
14:14:02 INFO - 1514 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 15 - correct tab was restored
14:14:02 INFO - 1515 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 16 - browser loaded correct url
14:14:02 INFO - 1516 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 16 - correct tab was restored
14:14:02 INFO - 1517 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 17 - browser loaded correct url
14:14:02 INFO - 1518 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 17 - correct tab was restored
14:14:02 INFO - 1519 INFO Longer timeout required, waiting longer... Remaining timeouts: 1
14:14:02 INFO - 1520 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 18 - browser loaded correct url
14:14:02 INFO - 1521 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 18 - correct tab was restored
14:14:02 INFO - 1522 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 1 - correct tab was reloaded
14:14:02 INFO - 1523 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 2 - correct tab was reloaded
14:14:02 INFO - 1524 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 3 - correct tab was reloaded
14:14:02 INFO - 1525 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 4 - correct tab was reloaded
14:14:02 INFO - 1526 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 5 - correct tab was reloaded
14:14:02 INFO - 1527 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 6 - correct tab was reloaded
14:14:02 INFO - 1528 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 7 - correct tab was reloaded
14:14:02 INFO - 1529 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 8 - correct tab was reloaded
14:14:02 INFO - 1530 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 9 - correct tab was reloaded
14:14:02 INFO - 1531 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 10 - correct tab was reloaded
14:14:02 INFO - 1532 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 11 - correct tab was reloaded
14:14:02 INFO - 1533 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 12 - correct tab was reloaded
14:14:02 INFO - 1534 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 13 - correct tab was reloaded
14:14:02 INFO - 1535 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 14 - correct tab was reloaded
14:14:02 INFO - 1536 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 15 - correct tab was reloaded
14:14:02 INFO - 1537 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 16 - correct tab was reloaded
14:14:02 INFO - 1538 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 17 - correct tab was reloaded
14:14:02 INFO - 1539 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 18 - correct tab was reloaded
14:14:02 INFO - 1540 INFO running testCascade
14:14:02 INFO - 1541 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 1 - correct tab was reloaded
14:14:02 INFO - 1542 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 2 - correct tab was reloaded
14:14:02 INFO - 1543 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 3 - correct tab was reloaded
14:14:02 INFO - 1544 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 4 - correct tab was reloaded
14:14:02 INFO - 1545 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 5 - correct tab was reloaded
14:14:02 INFO - 1546 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | load 6 - correct tab was reloaded
14:14:02 INFO - 1547 INFO running test_finish
14:14:02 INFO - 1548 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. - expected PASS
14:14:02 INFO - 1549 INFO TEST-OK | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-reload.js | took 96738ms
14:14:02 INFO - ++DOCSHELL 0x6aed0c00 == 98 [pid = 1860] [id = 2868]
14:14:02 INFO - ++DOMWINDOW == 241 (0x71f02380) [pid = 1860] [serial = 7768] [outer = (nil)]
14:14:03 INFO - ++DOMWINDOW == 242 (0x71f02f20) [pid = 1860] [serial = 7769] [outer = 0x71f02380]
14:14:03 INFO - [Parent 1860] WARNING: NS_ENSURE_TRUE(mMutable) failed: file /builds/slave/m-in-lx-d-00000000000000000000/build/netwerk/base/src/nsSimpleURI.cpp, line 265
14:14:03 INFO - 1550 INFO TEST-START | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-select.js
This is currently the #4 top orange. Can you please help find an owner, Gavin?
Flags: needinfo?(gavin.sharp)
Will do.
Flags: needinfo?(gavin.sharp) → needinfo?(ttaubert)
Might want to look at bug 1088092 while you're at it.
(Sorry this isn't a RB review request, tried to attach a file but couldn't get it to work. Will set up the proper infrastructure soon-ish. :)

I did the following:

1) Half the number of tabs/urls. I don't see why we would need 18 tabs instead of 9 to test what we want to test here.
2) We're now simply listening for SSTabRestore instead of using the weird gProgressListener
3) I completely removed testCascade(). Searching through VCS logs I found that the original comment for that function said it doesn't do much but tests that reloading works... which I find quite weird, after all the test covers reloading pending pages already. And reloading non-pending pages is surely covered by lots of other tests out there.
4) I removed reloadAllTabs() completely because that seems to just try to test browser reloading again, which we already did.

That test is quite adventurous.

https://tbpl.mozilla.org/?tree=Try&rev=6ae99cc2cf1e
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Flags: needinfo?(ttaubert)
Attachment #8522350 - Flags: review?(smacleod)
testCascade() was also pretty stupid in that it called setBrowserState() with restore_on_demand=false, then reloaded every browser and expected that to happen in order. I feel like that should have failed way before but it broke completely with e10s after I made a few changes.
Attachment #8522350 - Flags: review?(smacleod) → review+
https://hg.mozilla.org/mozilla-central/rev/fd2d738b5e26
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Blocks: 1088092
Iteration: --- → 36.3
Points: --- → 3
Flags: firefox-backlog+
Flags: qe-verify?
Flags: qe-verify? → qe-verify-
You need to log in before you can comment on or make changes to this bug.