108722 - OS X: Space no longer activates focused button

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[sairuh (rarely reading bugmail)]

the Space key no longer activates the focused button in dialogs. i've noticed
this on recent Mac OS X builds [eg, 2001.11.06.08-commercial], so it's a
regression. will check on OS 9.1 --but this isn't a problem on win32 and linux.

chris, pls do reassign as needed --not sure who'd own this...

1. open a dialog(*).
2. tab to any button to bring it into focus.
3. hit Space.

expected: button should indent [and text go from black->white, at least in
modern] and its particular function activated.

actual results: no indentation, no activation.

(*) tested with following dialogs:

Preferences
Open Web Location
Download progress dialog
Helper app dialog
Find dialog

fortunately, Return and Esc keys do work as expected.

Comment 1

[sairuh (rarely reading bugmail)]

nominating for moz0.9.7.

btw, this is not a problem on mac os 9.1.

Comment 2

[Mike Pinkerton (not reading bugmail)]

yup, this is a problem on both 9 and x with the carbon builds. seems like an
event handling issue. since it happens on 9, it should be pretty straightforward
to debug with the MWDebugger.

Comment 3

[Mike Pinkerton (not reading bugmail)]

oops, this is my bug. overzealous ifdefs. though it makes me realize that
composer doesn't seem to make use of OS key events at all. Even with the
dispatch of key events to gecko commented out, you can still type. strange.

Comment 4

[Simon Fraser [no longer active]]

>Even with the dispatch of key events to gecko commented out, you can still type. strange.

Yes, because we use the Unicode keyboard input Apple Events.

Comment 5

[Mike Pinkerton (not reading bugmail)]

here's the patch, but i still don't quite understand it

Index: mozilla/widget/src/mac/nsMacMessagePump.cpp
===================================================================
RCS file: /cvsroot/mozilla/widget/src/mac/nsMacMessagePump.cpp,v
retrieving revision 1.126
diff -u -2 -r1.126 nsMacMessagePump.cpp
--- nsMacMessagePump.cpp	2001/10/27 07:38:03	1.126
+++ nsMacMessagePump.cpp	2001/11/07 22:13:08
@@ -803,6 +803,6 @@
 	//else
 	{
-#if USE_MENUSELECT
 		PRBool handled = DispatchOSEventToRaptor(anEvent, 
GetFrontApplicationWindow());
+#if USE_MENUSELECT
 		/* we want to call this if cmdKey is pressed and no other modifier keys 
are pressed */
 		if((!handled) && (anEvent.what == keyDown) && (anEvent.modifiers == 
cmdKey) )

r/sr?

Comment 6

[saari (gone)]

r=saari

Comment 7

[Simon Fraser [no longer active]]

sr=sfraser

Comment 8

[Mike Pinkerton (not reading bugmail)]

checked in.

Comment 9

[sairuh (rarely reading bugmail)]

vrfy fixed with 2001.11.27.04-comm bits on 10.1.1.