1087254 - [B2G] Music sometimes can't get duration on mp3 file

Status: RESOLVED WONTFIX

(Core :: Audio/Video: Playback, defect)

Description

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

STR: 
1. play mp3
2. Unwind, check the duration, sometime it would show --

Comment 1

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Attachment: patch v1

https://mxr.mozilla.org/mozilla-central/source/content/media/omx/MediaOmxReader.cpp#273
This line won't be a block function call, 
On ProcessCachedData() job runs slower as usual case, the mUseParserDuration may not be set if mMP3FrameParser.IsMP3() check is failed, then the duration won't be update on MediaOmxReader::NotifyDataArrived().

Comment 2

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

The size of picture in the test mp3 file is 96.7kb. 
And the ProcessCachedData() would return after process the first block (~32kb) 
So if main thread run slower and ReadMetadata(on decoder thread) reach the //if (duration >= 0)//
Then mUseParserDuration won't be set..

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Not if MP3FrameParser::GetDuration can't return a valid duration (>= 0) after reading 32KB. Can you attach the problematic MP3 file and check how many bytes it needs to get a valid duration?

Comment 4

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Enable media codec would make this issue disappear.