1087361 - Ignore timeouts for compacting gc tests

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Jon Coppeard (:jonco)]

Currently the compacting GC tests on tbpl (confusingly named 'ggc') are orange because some of the jit-tests are timing out.

That's because things take much longer with compacting zeal mode on, so this is to be expected.  We should ignore timeouts on these specific tests.

Also, running jstests with this zeal mode takes an extremely long time (my local test run looked like it would take over 4 hours to complete), so we should disable jstests for this configuration.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: ignore-timeouts-for-cgc-tests

With this patch the 'ggc' tests are green.

Comment 2

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8509512 [details] [diff] [review]
ignore-timeouts-for-cgc-tests

Review of attachment 8509512 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/devtools/automation/autospider.sh
@@ +129,5 @@
>  $COMMAND_PREFIX $MAKE check || exit 1
>  $COMMAND_PREFIX $MAKE check-jit-test || exit 1
> +if [[ "$VARIANT" != "generational" ]]; then
> +    $COMMAND_PREFIX $MAKE check-jstests || exit 1
> +fi

This isn't strictly needed, I don't think. The check-jstests target is buggy, so it doesn't actually run anything on tbpl for any of these jobs. And I haven't fixed it yet because it's too slow even without this zeal setting, so I want to at least turn off the interpreter-only runs.

But I'm fine with landing this. I can believe that if it's slow for other builds, it'll be *really* slow with this zeal mode.

Comment 3

[Jon Coppeard (:jonco)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/19beeeec9cf3

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/19beeeec9cf3