1087378 - Stop using WindowProxy for IDL arguments

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

We unwrap to an inner window anyway, so it's silly.

Also, this is mostly used in init*Event, and per https://dvcs.w3.org/hg/dom3events/raw-file/tip/html/DOM3-Events.html draft those should take Window anyway.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Stop using WindowProxy for arguments in Web IDL; Window expresses what's going on more clearly

Comment 2

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4b4c7462ec89

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Backed out for bustage. If it helps, it appears to only be affecting builds that have unified compilation disabled (linux32 debug, static analysis, etc).
https://hg.mozilla.org/integration/mozilla-inbound/rev/a009be3f978a

https://treeherder.mozilla.org/ui/logviewer.html#?job_id=3405861&repo=mozilla-inbound

Comment 4

[Boris Zbarsky [:bzbarsky]]

Yeah, needs an nsGlobalWindow.h include in MessageEvent.cpp so we know we can assign it to an nsIDOMWindow*.

https://hg.mozilla.org/integration/mozilla-inbound/rev/8335aff95389

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8335aff95389