Closed Bug 1087378 Opened 5 years ago Closed 5 years ago

Stop using WindowProxy for IDL arguments

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(1 file)

We unwrap to an inner window anyway, so it's silly.

Also, this is mostly used in init*Event, and per https://dvcs.w3.org/hg/dom3events/raw-file/tip/html/DOM3-Events.html draft those should take Window anyway.
Attachment #8509547 - Flags: review?(peterv) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b4c7462ec89
Flags: in-testsuite-
Target Milestone: --- → mozilla36
Backed out for bustage. If it helps, it appears to only be affecting builds that have unified compilation disabled (linux32 debug, static analysis, etc).
https://hg.mozilla.org/integration/mozilla-inbound/rev/a009be3f978a

https://treeherder.mozilla.org/ui/logviewer.html#?job_id=3405861&repo=mozilla-inbound
Yeah, needs an nsGlobalWindow.h include in MessageEvent.cpp so we know we can assign it to an nsIDOMWindow*.

https://hg.mozilla.org/integration/mozilla-inbound/rev/8335aff95389
https://hg.mozilla.org/mozilla-central/rev/8335aff95389
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.