1087486 - l10n nightly builders shouldn't merge when enable_l10n_onchange isn't set

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Chris AtLee [:catlee]]

http://hg.mozilla.org/build/buildbotcustom/file/default/misc.py#l1222 populates l10nBuilders, but only if enable_l10n_onchange is set

http://hg.mozilla.org/build/buildbotcustom/file/default/misc.py#l1304 to populate nomergeBuilders for both dep *and* nightly l10n builders

this means that unless enable_l10n_onchange is set, we will merge nightly l10n jobs together, resulting in missing repacks for random locales.

Comment 1

[Chris AtLee [:catlee]]

Attachment: l10nonchange.diff

turns out most of this block is useless! We're iterating over these l10n builders elsewhere, so I update nomergeBuilders there instead, and dropped the calculation of l10n_binaryURL, which AFAICT isn't used anywhere.

Comment 2

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbotcustom/rev/00cd85f4b283