Closed
Bug 1087486
Opened 10 years ago
Closed 10 years ago
l10n nightly builders shouldn't merge when enable_l10n_onchange isn't set
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: catlee, Assigned: catlee)
References
Details
Attachments
(1 file)
|
3.20 KB,
patch
|
bhearsum
:
review+
catlee
:
checked-in+
|
Details | Diff | Splinter Review |
http://hg.mozilla.org/build/buildbotcustom/file/default/misc.py#l1222 populates l10nBuilders, but only if enable_l10n_onchange is set
http://hg.mozilla.org/build/buildbotcustom/file/default/misc.py#l1304 to populate nomergeBuilders for both dep *and* nightly l10n builders
this means that unless enable_l10n_onchange is set, we will merge nightly l10n jobs together, resulting in missing repacks for random locales.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → catlee
|
|
Assignee | |
Comment 1•10 years ago
|
||
turns out most of this block is useless! We're iterating over these l10n builders elsewhere, so I update nomergeBuilders there instead, and dropped the calculation of l10n_binaryURL, which AFAICT isn't used anywhere.
Attachment #8511321 -
Flags: review?(bhearsum)
|
||
Updated•10 years ago
|
Attachment #8511321 -
Flags: review?(bhearsum) → review+
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8511321 -
Flags: checked-in+
|
||
Comment 2•10 years ago
|
||
In production: https://hg.mozilla.org/build/buildbotcustom/rev/00cd85f4b283
|
|
Assignee | |
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•