1087615 - test_bug347174_write.html should always used an uncached image

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Seth Fowler [:seth] [:s2h]]

test_bug347174_write.html was specifically designed to use an uncached image; it achieved that by adding a different query parameter, based on the time, to the image URI for every load.

Unfortunately, it loaded that image from the network, which bug 628970 fixed. Bug 628970 also removed the query parameter, making the test just load 'image.png'. Since 'image.png' is also used by other tests that run before this one, we switched from a situation where test_bug347174_write.html *never* used a cached image to a situation where it *always* used a cached image.

This worked due to a quirk in the exact order that ImageLib delivered notifications. In bug 910441, I'm trying to clean up ImageLib's notification code, and to make that possible I need to restore this test's older, correct behavior.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: Always use an uncached image in test_bug347174_write.html

This patch restores the original behavior from before bug 628970. (But maintains bug 628970's change of using a local image instead of a network load.)

Comment 2

[Seth Fowler [:seth] [:s2h]]

Here's a try job:

https://tbpl.mozilla.org/?tree=Try&rev=9c70b582f8e2

Comment 3

[Seth Fowler [:seth] [:s2h]]

Attachment: Always use an uncached image in test_bug347174_write.html

Thanks for the review! I rebased the patch.

Comment 4

[Seth Fowler [:seth] [:s2h]]

Pushed:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=b843e38a948f

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b843e38a948f