1087673 - Vibrate on long back press

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

In both Android UI and in-page links, we vibrate when the user long presses an item. We could do the same thing for the phone's back button when showing the history menu.

Comment 1

[Vivek Balakrishnan[:vivek]]

I would like to take this up as it is related to my current fix for 847435

Comment 2

[Vivek Balakrishnan[:vivek]]

Attachment: 1087673.patch

Vibration enabled for 100 milliseconds when showing the tab history.

Comment 3

[Brian Nicholson (:bnicholson)]

Comment on attachment 8519425 [details] [diff] [review]
1087673.patch

Review of attachment 8519425 [details] [diff] [review]:
-----------------------------------------------------------------

Have you tried unchecking the "vibrate on touch" pref in Settings to verify that it doesn't vibrate? We need to make sure we're honoring the system's haptic feedback pref.

::: mobile/android/base/resources/values/integers.xml
@@ +7,5 @@
>  
>      <integer name="number_of_top_sites">6</integer>
>      <integer name="number_of_top_sites_cols">2</integer>
>      <integer name="max_icon_grid_columns">4</integer>
> +    <integer name="tab_history_vibrate_duration_in_msecond">100</integer>

Nit: Please rename this to long_press_vibrate_msec. Having a generic name is useful if we end up using vibration anywhere else.

Comment 4

[Vivek Balakrishnan[:vivek]]

Attachment: 1087673.patch

Review comments addressed.
Android "vibrate on touch" settings honoured.

Comment 5

[Brian Nicholson (:bnicholson)]

Comment on attachment 8520727 [details] [diff] [review]
1087673.patch

Review of attachment 8520727 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 6

[Brian Nicholson (:bnicholson)]

Don't forget, there are a couple of things that need to be done before we can set checkin-needed:
* The patch should contain the bug #, a summary of what was fixed, and the r=<reviewer> note.
* There should be a link to a try push in the bug.

Comment 7

[Vivek Balakrishnan[:vivek]]

Attachment: 1087673.patch

patch summary updated

Try run log:
https://tbpl.mozilla.org/?tree=Try&rev=a69c0c6c9b4e

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Needs rebasing.

Comment 9

[Vivek Balakrishnan[:vivek]]

Attachment: 1087673.patch

Rebased with latest tree

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8520975 [details] [diff] [review]
1087673.patch

There's no harm in marking bugs obsolete and it makes the attachment list easier to read :)

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/95751725d539

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/95751725d539