1087730 - Make JS callers of ios.newChannel call ios.newChannel2 in extensions/

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Comment 1

[Christoph Kerschbaumer [:ckerschb, back Sept 8th]]

Attachment: js_6_extensions.patch

Monica, in Bug 1038756 we started attaching a loadInfo to every channel whenever the channel gets created through NS_NewChannel in nsNetUtil.h. Now we are expanding the loadInfo attachment to also include channels that get created within JS to ultimately end up having a loadInfo on every channel.

Please note that this bug is dependent on Bug 1095798 which adds newChannel2 to NetUtil.jsm (which is about to land on inbound today). Anyway, please find a description of all the required arguments to create a channel here [1] or alternatively here [2].

Since all the channels created in this patch are created in some kind of test-environment, I believe that the arguments provided should be accurate. But please double check. If there are more appropriate arguments to use, please let me know. Thanks!

[1] http://mxr.mozilla.org/mozilla-central/source/netwerk/base/public/nsNetUtil.h#202
[2] http://mxr.mozilla.org/mozilla-central/source/netwerk/base/public/nsIIOService.idl#76

Comment 2

[[:mmc] Monica Chew (no longer reading bugmail)]

Comment on attachment 8536705 [details] [diff] [review]
js_6_extensions.patch

Review of attachment 8536705 [details] [diff] [review]:
-----------------------------------------------------------------

I took a look at https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=1095798&attachment=8536718 and this looks all right to me. Thanks for fixing!

Comment 3

[Christoph Kerschbaumer [:ckerschb, back Sept 8th]]

 https://hg.mozilla.org/integration/mozilla-inbound/rev/cf04310e7cba

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cf04310e7cba