Make JS callers of ios.newChannel call ios.newChannel2 in modules/

RESOLVED FIXED in mozilla37

Status

()

Core
DOM: Security
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ckerschb, Assigned: ckerschb)

Tracking

unspecified
mozilla37
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Updated

3 years ago
Blocks: 1087720
(Assignee)

Updated

3 years ago
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
(Assignee)

Comment 1

3 years ago
Created attachment 8538865 [details] [diff] [review]
js_11_modules.patch

And more callsites we have to revisit :-)
Attachment #8538865 - Flags: feedback?(tanvi)
(Assignee)

Comment 2

3 years ago
Created attachment 8540873 [details] [diff] [review]
js_11_modules.patch

Michael, in Bug 1038756 we started attaching a loadInfo to every channel whenever the channel gets created through NS_NewChannel in nsNetUtil.h. Now we are expanding the loadInfo attachment to also include channels that get created within JS to ultimately end up having a loadInfo on every channel.  Please find a description of all the required arguments to create a channel here [1] or alternatively here [2].

As far I was able to evaluate, all the files we touched in this patch are tests only. I assume using default arguments (systemPrincipal, type_other, and sec_normal) should be fine. However, please take a look and let us know if there are more descriptive/accurate arguments which we should use.

Thank you!

[1] http://mxr.mozilla.org/mozilla-central/source/netwerk/base/public/nsNetUtil.h#209
[2] http://mxr.mozilla.org/mozilla-central/source/netwerk/base/public/nsIIOService.idl#73
Attachment #8538865 - Attachment is obsolete: true
Attachment #8538865 - Flags: feedback?(tanvi)
Attachment #8540873 - Flags: review?(mwu)

Updated

3 years ago
Attachment #8540873 - Flags: review?(mwu) → review+
(Assignee)

Comment 3

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/d9306cec6ff8
Target Milestone: --- → mozilla37
https://hg.mozilla.org/mozilla-central/rev/d9306cec6ff8
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.