1087738 - Make JS callers of ios.newChannel call ios.newChannel2 in modules/

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Comment 1

[Christoph Kerschbaumer [:ckerschb}]

Attachment: js_11_modules.patch

And more callsites we have to revisit :-)

Comment 2

[Christoph Kerschbaumer [:ckerschb}]

Attachment: js_11_modules.patch

Michael, in Bug 1038756 we started attaching a loadInfo to every channel whenever the channel gets created through NS_NewChannel in nsNetUtil.h. Now we are expanding the loadInfo attachment to also include channels that get created within JS to ultimately end up having a loadInfo on every channel.  Please find a description of all the required arguments to create a channel here [1] or alternatively here [2].

As far I was able to evaluate, all the files we touched in this patch are tests only. I assume using default arguments (systemPrincipal, type_other, and sec_normal) should be fine. However, please take a look and let us know if there are more descriptive/accurate arguments which we should use.

Thank you!

[1] http://mxr.mozilla.org/mozilla-central/source/netwerk/base/public/nsNetUtil.h#209
[2] http://mxr.mozilla.org/mozilla-central/source/netwerk/base/public/nsIIOService.idl#73

Comment 3

[Christoph Kerschbaumer [:ckerschb}]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d9306cec6ff8

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d9306cec6ff8