Closed Bug 1087797 Opened 10 years ago Closed 10 years ago

[User Story] Ensure that 1.1 Loop Mobile application version can only be installed in Fire E devices with (at least) 2.0 FxOS version

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Loop
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: oteo, Assigned: crdlc)

References

Details

(Whiteboard: [mobile app][loop in v1.1][loop approved for 1.1])

User Story

Right now Market Place is not offering yet the feature to allow or not the download of an application restricting by FxOS version or type of device so we need to provide a workaround for 1.1 Loop Mobile app version.

As a user, when launching Loop mobile app, I will be notified that I can NOT use in case:
- the Firefox OS version installed in my device is lower than 2.0 or
- my Device is not compatible with Loop (this is determined by a list of compatible devices in Loop app)

Attachments

(2 files)

Error messages provided by UX to cover
57.03 KB, application/pdf
Details
Github pull request
204 bytes, text/html
jaoo
: review+
jaoo
: feedback+
Details 
As Market Place is not offering yet the feature to allow or not the download of an application restricting by FxOS version or type of device, we need to provide a workaround for 1.1 Loop Mobile app version.

These FxOS version and device checkings and the corresponding message errors will be done/shown when launching the application.

It would be great if we can configure the list of supported devices (via a configuration parameter) so we can test with other devices during the development time.
Blocks: MP_Loop1.1
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Severity: normal → critical
Attached file Github pull request — 
The patch is completely configurable in a JSON file.

{
  "device": {
    "names": [
      "ALCATELOneTouch6015X",
      "Mozilla"
    ]
  },
  "os": {
    "minimumMajorVersion": 32
  }
}

Note: I added "Mozilla" as supported device in order to be able to run Loop in all FFOS devices right now. Once Loop will be uploaded to market place this file should be modified to define what devices are supported.
Attachment #8510223 - Flags: review?(josea.olivera)
Whiteboard: [mobile app]
Comment on attachment 8510223 [details]
Github pull request

Thanks Cristian, this is looking great. I left a few comments on the PR. Please have a look at it. Thanks!
Attachment #8510223 - Flags: review?(josea.olivera) → feedback+
Comment on attachment 8510223 [details]
Github pull request

thanks Jose
Attachment #8510223 - Flags: review?(josea.olivera)
Comment on attachment 8510223 [details]
Github pull request

LGTM. r=me

Thanks for taking care of it Cristian!
Attachment #8510223 - Flags: review?(josea.olivera) → review+
Merged in master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/60c585a336cf19fe44c62099ee4900574816c3d8
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [mobile app] → [mobile app][loop not in v1.1]
User Story: (updated)
Summary: [Loop] Ensure that 1.1 Loop Mobile application version can only be installed in Fire E devices with (at least) 2.0 FxOS version → [User Story] Ensure that 1.1 Loop Mobile application version can only be installed in Fire E devices with (at least) 2.0 FxOS version
Blocks: Loopmov_1_1
Whiteboard: [mobile app][loop not in v1.1] → [mobile app][loop not in v1.1][loop approved for 1.1]
Cristian, although QA team didn't have time to test it properly in master, let's uplift it to 1.1 branch and QA will verify it on that branch tomorrow.
Flags: needinfo?(crdlc)
in 1.1:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/7fc9307e769cc92b38e995b8ae9b4e55bf211f4c
Flags: needinfo?(crdlc)
Whiteboard: [mobile app][loop not in v1.1][loop approved for 1.1] → [mobile app][loop in v1.1][loop approved for 1.1]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: