gfx/thebes/ContextStateTracker.cpp:8:29: fatal error: ProfilerMarkers.h: No such file or directory (non-SPS)

RESOLVED FIXED in mozilla36

Status

()

Core
Graphics
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Jan Beich, Assigned: BenWa)

Tracking

Trunk
mozilla36
All
FreeBSD
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.31 KB, patch
Details | Diff | Splinter Review
(Reporter)

Description

3 years ago
On platforms lacking SPS profiler (Linux/PPC, BSDs, Solaris) the build is broken because of missing MOZ_ENABLE_PROFILER_SPS ifdefs.

gfx/thebes/ContextStateTracker.cpp:8:10: fatal error:
      'ProfilerMarkers.h' file not found
#include "ProfilerMarkers.h"
         ^
1 error generated.
(Reporter)

Updated

3 years ago
Summary: gfx/thebes/ContextStateTracker.cpp:8:29: fatal error: ProfilerMarkers.h: No such file or directory → gfx/thebes/ContextStateTracker.cpp:8:29: fatal error: ProfilerMarkers.h: No such file or directory (non-SPS)
(Assignee)

Comment 1

3 years ago
Created attachment 8510036 [details] [diff] [review]
patch
(Reporter)

Comment 2

3 years ago
Created attachment 8510037 [details] [diff] [review]
fix

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=33d5bd60cbe0
Attachment #8510037 - Flags: review?(bgirard)
(Assignee)

Comment 3

3 years ago
Wont you get an error on missing GPUMarkerPayload?
(Reporter)

Comment 4

3 years ago
Comment on attachment 8510037 [details] [diff] [review]
fix

Oh, I've lost the race by 5 seconds. ;)
Attachment #8510037 - Attachment is obsolete: true
Attachment #8510037 - Flags: review?(bgirard)
(Assignee)

Comment 5

3 years ago
Can you confirm this patch is sufficient and that I haven't missed anything else before we land this?
(Reporter)

Comment 6

3 years ago
(In reply to Benoit Girard (:BenWa) from comment #3)
> Wont you get an error on missing GPUMarkerPayload?

No, the call is erased by C preprocessor. See PROFILER_MARKER_PAYLOAD() stub in GeckoProfiler.h.

(In reply to Benoit Girard (:BenWa) from comment #5)
> Can you confirm this patch is sufficient and that I haven't missed anything
> else before we land this?

My build succeeds with either patch. Try is green as well.
(Assignee)

Comment 7

3 years ago
Cool, sorry for the hassle!

https://hg.mozilla.org/integration/mozilla-inbound/rev/bda942a971c2
https://hg.mozilla.org/mozilla-central/rev/bda942a971c2
Assignee: nobody → bgirard
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.