On platforms lacking SPS profiler (Linux/PPC, BSDs, Solaris) the build is broken because of missing MOZ_ENABLE_PROFILER_SPS ifdefs. gfx/thebes/ContextStateTracker.cpp:8:10: fatal error: 'ProfilerMarkers.h' file not found #include "ProfilerMarkers.h" ^ 1 error generated.
Wont you get an error on missing GPUMarkerPayload?
Comment on attachment 8510037 [details] [diff] [review] fix Oh, I've lost the race by 5 seconds. ;)
Can you confirm this patch is sufficient and that I haven't missed anything else before we land this?
(In reply to Benoit Girard (:BenWa) from comment #3) > Wont you get an error on missing GPUMarkerPayload? No, the call is erased by C preprocessor. See PROFILER_MARKER_PAYLOAD() stub in GeckoProfiler.h. (In reply to Benoit Girard (:BenWa) from comment #5) > Can you confirm this patch is sufficient and that I haven't missed anything > else before we land this? My build succeeds with either patch. Try is green as well.
Cool, sorry for the hassle! https://hg.mozilla.org/integration/mozilla-inbound/rev/bda942a971c2