Closed Bug 1087855 Opened 10 years ago Closed 10 years ago

fxam_errors_test.js misprint

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: sv99, Assigned: zbraniecki)

References

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20141019030207

Steps to reproduce:

line 12 misprint, missed ',' 
JavaScript error: app://system.gaiamobile.org/test/unit/fxa_test/fxam_errors_test.js?time=1414036155191, line 13: SyntaxError: missing } after property list


Actual results:

1 step
after insert ',' in line 12 - all test filed!
first error
JavaScript error: app://system.gaiamobile.org/fxa/js/fxam_errors.js?time=1414036356166, line 8: TypeError: navigator.mozL10n is undefined

2 step
Add to fxam_errors_test.js 
require('/shared/js/l10n.js');

  1) [system-test/unit/fxa_test/fxam_errors_test.js] Error manager Test CONNECTION_ERROR:
     Error: expected get to be called with arguments fxa-connection-error-title
      at fail (app://system.gaiamobile.org/common/vendor/sinon/sinon.js:4712:25)

in FxaModuleErrors.responseToParams(response);
sinon.spy(navigator.mozL10n.get); -> called = 0 times!!
Flags: needinfo?(zbraniecki)
Bug 1073893: Clean up MozL10n API use in System - remove call _(...) !!! test not may work properly
Flags: needinfo?(zbraniecki)
Flags: needinfo?(zbraniecki)
Taking
Assignee: nobody → gandalf
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Caused by bug 987418. I cannot believe we didn't notice it since March. I don't know what to think about unit tests that silently fail on syntax errors in the test suit.
Blocks: 987418
Flags: needinfo?(zbraniecki)
Attached file pull request
Jared, does this patch looks good to you?
Attachment #8510604 - Flags: review?(6a68)
Attachment #8510604 - Flags: review?(6a68) → review?(ferjmoreno)
Comment on attachment 8510604 [details] [review]
pull request

Thanks Zibi
Attachment #8510604 - Flags: review?(ferjmoreno) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: