1087855 - fxam_errors_test.js misprint

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[sv99]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20141019030207

Steps to reproduce:

line 12 misprint, missed ',' 
JavaScript error: app://system.gaiamobile.org/test/unit/fxa_test/fxam_errors_test.js?time=1414036155191, line 13: SyntaxError: missing } after property list


Actual results:

1 step
after insert ',' in line 12 - all test filed!
first error
JavaScript error: app://system.gaiamobile.org/fxa/js/fxam_errors.js?time=1414036356166, line 8: TypeError: navigator.mozL10n is undefined

2 step
Add to fxam_errors_test.js 
require('/shared/js/l10n.js');

  1) [system-test/unit/fxa_test/fxam_errors_test.js] Error manager Test CONNECTION_ERROR:
     Error: expected get to be called with arguments fxa-connection-error-title
      at fail (app://system.gaiamobile.org/common/vendor/sinon/sinon.js:4712:25)

in FxaModuleErrors.responseToParams(response);
sinon.spy(navigator.mozL10n.get); -> called = 0 times!!

Comment 1

[sv99]

Bug 1073893: Clean up MozL10n API use in System - remove call _(...) !!! test not may work properly

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Taking

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Caused by bug 987418. I cannot believe we didn't notice it since March. I don't know what to think about unit tests that silently fail on syntax errors in the test suit.

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: pull request

Jared, does this patch looks good to you?

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8510604 [details] [review]
pull request

Thanks Zibi

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Commit: https://github.com/zbraniecki/gaia/commit/73f6ea071f1c1cbc33f3ec79e9b2f70064e72ec1
Merge: https://github.com/mozilla-b2g/gaia/commit/ce3e700ee65b725ca111c2588ad525398b966e59