108791 - classic theme: crash when accessing the Autocomplete Prefs dialog

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect)

Description

[sairuh (rarely reading bugmail)]

found this using 2001.11.06.08-comm bits on mac os 10.1. only occurs with
classic theme, not in modern.

1. open Preferences dialog and go to the Smart Browsing panel.
2. in the "Location Bar Autocomplete" section, click the "Advanced" button.

result: crash.

has anyone seen this on mac os 9.x? it doesn't happen on win32 or linux.

Comment 1

[sairuh (rarely reading bugmail)]

drat, i'm not having luck getting trace info... anyone else?

will try a few other things to get more crash info...

Comment 2

[sairuh (rarely reading bugmail)]

also crashes on 9.1 --however, the talkback trace was useless. will attach
macsbug trace soon.

Comment 3

[sairuh (rarely reading bugmail)]

Attachment: macsbug trace

Comment 4

[Simon Fraser [no longer active]]

Looks like nsEventStateManager::ShiftFocus() is recursing and blowing the stack.

Comment 5

[Diego Biurrun]

dupe of bug 108714 ?

Comment 6

[Simon Fraser [no longer active]]

No, stack is different.

Comment 7

[Joe Hewitt (gone)]

OS X stuff -> sfraser

Comment 8

[sairuh (rarely reading bugmail)]

joe, this also crashes on Mac OS 9.x --it isn't limited to OS X.

Comment 9

[ck]

This also happened to me just minutes ago on 9.1. Crashed into macsbug, "es"
would not work, had to reboot.

Comment 10

[Chris Lyon]

*** Bug 111902 has been marked as a duplicate of this bug. ***

Comment 11

[Simon Fraser [no longer active]]

Does this still happen?

Comment 12

[sairuh (rarely reading bugmail)]

yep, still crashing --at least with a build from 2001.12.10.08 [commercial].

Comment 13

[ck]

Problem still happens with 0.9.7 running under Mac OS 9.1. I will attach a
macsbug trace.

Comment 14

[ck]

Attachment: MacsBug trace: Mozilla 0.9.7 running under Mac OS 9.1.

Comment 15

[andreww]

I encountered this today - totally trashed my system... with the little "bomb"
icon...

Comment 16

[sairuh (rarely reading bugmail)]

*** Bug 121715 has been marked as a duplicate of this bug. ***

Comment 17

[Simon Fraser [no longer active]]

Note that bug 112993 shows a similar stack trace.

Comment 18

[Simon Fraser [no longer active]]

The problem here is that nsEventStateManger::ShiftFocus can find nothing to focus 
(since Mac classic skin doesn't have all focussable widgets), so it just recurses 
to death.

Comment 19

[Brian Ryner (not reading)]

Attachment: patch

This should guard against the infinite recursion.  If we pass the end of the
same document twice while looking for focusable content, we'll stop.

Comment 20

[Simon Fraser [no longer active]]

Comment on attachment 67174 [details] [diff] [review]
patch

Tested the patch, it fixes the crash and works fine. sr=sfraser

Comment 21

[saari (gone)]

Comment on attachment 67174 [details] [diff] [review]
patch

r=saari

Comment 22

[Brian Ryner (not reading)]

checked in.

Comment 23

[David :Bienvenu]

*** Bug 112993 has been marked as a duplicate of this bug. ***

Comment 24

[sairuh (rarely reading bugmail)]

vrfy'd fixed using 2002.02.04.17 comm bits on 10.1.2. no more crashing!

Comment 25

[Simon Fraser [no longer active]]

*** Bug 123796 has been marked as a duplicate of this bug. ***

Comment 26

[(not reading, please use [e-mail] instead)]

see also bug #195011 (and bug #137191, which are nearly dups.)

these is another version of this bug that involve xul documents with browser
elements, which we try to tab into.