Closed
Bug 1087951
Opened 11 years ago
Closed 11 years ago
"Cancel" button is not localized when removing a call or a shared link from log
Categories
(Firefox OS Graveyard :: Gaia::Loop, defect)
Firefox OS Graveyard
Gaia::Loop
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: flod, Assigned: crdlc)
References
Details
(Whiteboard: [mobile app][blocking][tef-triage][loop approved for 1.1][loop in 1.1])
Attachments
(1 file)
Tap on a log item, either in the Calls or Shared links panel: the "Cancel" button at the bottom is not localized.
The same button is correctly localized if I select "Clean shared links" from Settings.
Gaia-Rev 3c901411771b4854c07c300ebcded0a793c625ed
Gecko-Rev https://hg.mozilla.org/mozilla-central/rev/15099ba111e8
Build-ID 20141021160207
Version 36.0a1
Device-Name flame-kk
FW-Release 4.4.2
FW-Incremental 34
FW-Date Tue Sep 30 14:06:36 CST 2014
Bootloader L1TC00011840
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
|
||
Comment 2•11 years ago
|
||
We need to fix this and uplift it to 1.1 when it lands in master, so setting already the approval for the 1.1 branch.
Whiteboard: [mobile app] → [mobile app][blocking][tef-triage][loop approved for 1.1]
|
|
||
Updated•11 years ago
|
Severity: normal → major
|
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8510239 [details]
Github pull request
changing the revisor as it was wrong before :)
|
|
||
Comment 4•11 years ago
|
||
(In reply to Maria Angeles Oteo (:oteo) from comment #3)
> changing the revisor as it was wrong before :)
nothing was wrong, only me, sorry
|
||
Comment 5•11 years ago
|
||
Comment on attachment 8510239 [details]
Github pull request
LGTM. r=me
Thanks Cristian!
Attachment #8510239 -
Flags: review?(josea.olivera) → review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
Merged in master:
https://github.com/mozilla-b2g/firefoxos-loop-client/commit/981820666daf2eee4d74e694404d1517bb5af2b3
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 7•11 years ago
|
||
in 1.1:
https://github.com/mozilla-b2g/firefoxos-loop-client/commit/84940595f81a82bb7e9cdb0d9d3bed050214c7c0
Whiteboard: [mobile app][blocking][tef-triage][loop approved for 1.1] → [mobile app][blocking][tef-triage][loop approved for 1.1][loop in 1.1]
|
||
Comment 8•11 years ago
|
||
Verified on flame:
user.v2.0.184based.B-49.Gecko-675d616.Gaia-2183b4f
eng.v2.0.184based.B-43.Gecko-675d616.Gaia-2183b4f
RAM: 5132M
FireE: v2.0-SW2E3-1
Loop Version 1.1: ofbfc03
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•