1088013 - On dutch locale, the virtual keyboard doesn't come up on FxOS 2.1

Status: RESOLVED DUPLICATE of bug 998106

(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect)

Description

[Martijn Wargers (dead)]

This is on FxOS2.1 on the Flame device from today's build.
When I choose "Nederlands" (dutch locale) as language, then go to wifi setting, when I then try to enter the wifi password, the virtual keyboard doesn't come up, when tapping on the text input.

When I go further, it turns out the virtual keyboard never appears.

(I vaguely remember I brought this issue up, earlier)

Comment 1

[Martijn Wargers (dead)]

I see this in logcat:
E/GeckoConsole(  212): [JavaScript Error: "TypeError: this.keyboardLayouts[groupInfo.group] is undefined" {file: "app://system.gaiamobile.org/js/keyboard_manager.js" line: 492}]

Comment 2

[Martijn Wargers (dead)]

Tim, do you know what's going on here?

Comment 3

[Tony Chung [:tchung]]

[Blocking Requested - why for this release]:

based on First run and choosing a non-english keyboard (ie. Dutch here), this doesnt reproduce if he uses english on startup.

Comment 4

[Tony Chung [:tchung]]

qawanted to see if this reproduces on 2.0, base image v188.

Comment 5

[Martijn Wargers (dead)]

Regarding comment 0, this was using base image v188.

Comment 6

[Seth Miko [:SMiko]]

This issue does NOT repro on Flame 2.0 (base only/v188) as the affected languages do not exist.

Actual result: Keyboard appears in FTU.
__________________________________________________________________________________________________________________________________________

This issue DOES repro on Flame 2.0 (319mb/full flash/v188)

Actual result: Keyboard does NOT appear in FTU when selecting specific languages. (Dutch,Bulgarian,Czech...)

Device: Flame 2.0
BuildID: 20141023000201
Gaia: ec722129a962704fda0dd5f39e7efd01261ae946
Gecko: 307385ce7341
Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d
Version: 32.0 (2.0)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
___________________________________________________________________________________________________________________________________________

Leaving QA Wanted flag for a list of affected languages.

Comment 7

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
Nominating to block on the basis set in Comment 3 now that we've determined 2.0 is affected.

Comment 8

[Martijn Wargers (dead)]

I can also reproduce on trunk (2.2 engineering build) and on 2.0 engineering builds.

Just to be clear, exact steps to reproduce:
- Start up the device for the first time
- You get to see the language selector, choose "Nederlands" (=dutch)
- Tap on "Volgende" 3 times, until you get to the network choose dialog
- Tap on the network you want to join, then tap on the input to put in the password

Expected result:
- Virtual keyboard comes up

Actual result:
- Virtual keyboard doesn't come up

Afterwards, the virtual keyboard doesn't show at all, not on any input. Only after you've switched back to english, you get to see the vkb again.

Comment 9

[Martijn Wargers (dead)]

Attachment: logcat.txt

Full logcat from trunk build.

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Maybe this is because we are enabling a keyboard layout that is not shipped when the locale is selected? If so I would argue WONTFIX because that would be an incorrect build config.

Alternatively, we can be a bit smarter on constructing that keyboard_layouts.json during build to work against this kind of incorrect build config.

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

That JS error might be unrelated, but still need to be addressed.

Comment 12

[John Lu [:mnjul][Please NI or I'll miss]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #11)
> That JS error might be unrelated, but still need to be addressed.

It's the same root cause: The necessary layouts weren't built and weren't written into settings, so KeyboardManager did not have any applicable layouts, loaded/parsed by KeyboardHelper, to show for the text/password input type.

Comment 13

[John Lu [:mnjul][Please NI or I'll miss]]

We can definitely fallback to some layout (maybe using bug 1035117), but we need to agree on what the desirable behavior should be.

Say we don't ship Netherlands keyboard but with language support -- what keyboard would the user want to see and use?

NI Martijn and Omega for some input.

Comment 14

[Omega Feng [:Omega] [:馮於懋]]

I don't think we should let that case happen. But if we don't ship Netherlands keyboard but with language support, just fallback to English keyboard.

Comment 15

[Tony Chung [:tchung]]

see comment 6.  there are other locales affected.   qawanted to get a full list of what other ones are having this problem, not just dutch.

Comment 16

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Since this is not a correct build config for production, I would argue this shouldn't be a blocker. Anyway, triage team can make call.

(In reply to Omega Feng [:Omega] [:馮於懋] (please ni?) from comment #14)
> I don't think we should let that case happen. But if we don't ship
> Netherlands keyboard but with language support, just fallback to English
> keyboard.

UX have spoken. John or Rudy, please figure out who should take this, thanks!

Comment 17

[Tim Guan-tin Chien [:timdream] (please needinfo)]

BTW if we finish bug 1029951 we should be able to ship all layouts, just not the correction dictionary.

Comment 18

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

With an offline discussion with Tim and John, since this originated from a build config, we should tackle this issue from build scripts.
That is to say, build/keyboard-layouts.js should not only create a language -> keyboard layout mapping, but also check whether the corresponding keyboard layouts are enabled in this build or not.
It should filter out the layouts that are not enabled and add a fallback layout, like English when the layout set is empty.

Comment 19

[Martijn Wargers (dead)]

(In reply to John Lu [:mnjul] [MoCoTPE] from comment #13)
> We can definitely fallback to some layout (maybe using bug 1035117), but we
> need to agree on what the desirable behavior should be.
> 
> Say we don't ship Netherlands keyboard but with language support -- what
> keyboard would the user want to see and use?
> 
> NI Martijn and Omega for some input.

The English keyboard would just be fine for the Netherlands, I think.

Comment 20

[Cody Roesch [:croesch]]

Here is a list of Languages missing keyboards

Flame 2.0
---------
Bulgarian
Catalan
Czech
Danish
Croation
Hungarian
Italian
Japanese
Khmer
Kannada
Macedonian
Dutch
Romanian
Slovak
Serbian
Srpski - Serbo/Croation
Swedish
Swahili
Turkish

---------
Flame 2.1
---------

Belarusian
Bulgarian
Bosnian
Catalan
Czech
Danish
Irish
Gaelic (Scotland)
Croation
Hungarian
Italian
Macedonian
Dutch
Portuguese (Europeu)
Romanian
Slovak
Albanian
Serbian
Srpski - serbo/Croation
Swedish
Swahili
Turkish

Comment 21

[KTucker [:KTucker][Inactive 3/4/2016]]

I believe this to be a dupe of Bug 998106

Comment 23

[Tony Chung [:tchung]]

clearing blocking nom, and tracking bug over in 9998106