1088051 - [B2G][Gallery] Attempt to edit photo while it is being deleted, get stuck in photo edit window

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Robert Wood [:rwood]]

Build Information
Gaia-Rev        1e48e3e40e0780c0cd07a3457e5fe2efeeb542d1
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/09fb60a37850
Build-ID        20141023001201
Version         34.0
Device-Name     flame
Base image: ***Please update this field to say if you're running the v180 or the v188 base image***


Description
Able to edit a photo after choosing to delete it.

Steps to Reproduce
- Start Gallery app
- Click on a photo thumbnail to enlarge photo
- Click the delete icon
- Click the red delete button, then when returned to the photo immediately click the edit icon (before the photo is deleted)

Expected Results
- Since you have chosen to delete the photo, the edit button should be disabled when you are returned to the photo for the short time before it is deleted

Actual Results
- A blank Edit window opens, and you get stuck in the Edit window - clicking "Done" or the "X" does nothing
- Must close the Gallery app via homescreen button/app switcher. Gallery app will restart fine

Other Notes


Reproduction Frequency: Constant

Comment 1

[Tony Chung [:tchung]]

is this a timing issue?   certainly an edge case, wont block, but if this is reproducible with proper timing, then can nom for blocking.

Comment 2

[No-Jun Park [:njpark]]

(In reply to Tony Chung [:tchung] from comment #1)
> is this a timing issue?   certainly an edge case, wont block, but if this is
> reproducible with proper timing, then can nom for blocking.

So the problem is that after pressing delete, the edit button (and other buttons) are ready to accept the input for a good 2 seconds.  If the user does anything during that 2 seconds with the deleted photo, it'll freeze the app.  Since it's quite easy to repro, maybe we should block it.  what do you think?

Comment 3

[Tony Chung [:tchung]]

[Blocking Requested - why for this release]:

(In reply to No-Jun Park [:njpark] from comment #2)
> (In reply to Tony Chung [:tchung] from comment #1)
> > is this a timing issue?   certainly an edge case, wont block, but if this is
> > reproducible with proper timing, then can nom for blocking.
> 
> So the problem is that after pressing delete, the edit button (and other
> buttons) are ready to accept the input for a good 2 seconds.  If the user
> does anything during that 2 seconds with the deleted photo, it'll freeze the
> app.  Since it's quite easy to repro, maybe we should block it.  what do you
> think?

2 seconds is a lot of user time to do something they shouldnt do.  since its easy to reproduce and make mistakes, and the user gets stuck in gallery edit mode and needs to force quit the app, thats horrible user experience.   Lets get this nom'd.   

ni? hema and djf to assess how risky and timely can this be fixed.

Comment 4

[Stephany Wilkes]

Agree this should block. This is the sort of thing that kills us in the market. Thanks Tony!

Comment 5

[Dietrich Ayala (:dietrich)]

Blocking+ for regression.

Comment 6

[Punam Dahiya [:pdahiya]]

This issue was reported as part of bug 1048416. See https://bugzilla.mozilla.org/show_bug.cgi?id=1048416#c5 for the revised STR of that bug. 

We have a fix for this issue, I will attach the patch after updating it with David's review feedback from https://bugzilla.mozilla.org/show_bug.cgi?id=1048416#c13.

This issue is difficult to replicate in 2.2 as with the fix of bug 1050129 deleting an image is faster and no more takes ~2 secs. David, Will it be safe to uplift bug 1050129 patch to 2.1 to improve delete and save edited images time in 2.1?

Comment 7

[Punam Dahiya [:pdahiya]]

Attachment: PR with fix of Bug 1088051

Hi David
Attaching the PR updated with review feedback from https://bugzilla.mozilla.org/show_bug.cgi?id=1048416#c13.

As this issue is easily replicable in 2.1, Here's the 2.1 version of this fix
https://github.com/mozilla-b2g/gaia/pull/25634

Please review. Thanks!

Comment 8

[Hema Koka [:hema]]

We are on it. Clearing NI's

Comment 9

[David Flanagan [:djf]]

Comment on attachment 8513789 [details] [review]
PR with fix of Bug 1088051

Thanks Punam. Both the master and 2.1 PRs look good to me. One nit noted on github, but just about a comment, so I'm fine with landing these as is.

And yes, I'd be fine with uplifting 1050129 as well. That's a significant user visible performance improvement and is a one-line fix that is has been running without issues on master for a while now. Feel free to request uplift for it.

Comment 10

[Punam Dahiya [:pdahiya]]

Thanks David for review, patch landed on master

https://github.com/mozilla-b2g/gaia/commit/fe28d7806085ea6172081467496540c0a320c1f4

Comment 11

[Punam Dahiya [:pdahiya]]

Comment on attachment 8513789 [details] [review]
PR with fix of Bug 1088051

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Existing issue that can be replicated in 1.4, 2.0, 2.1

[User impact] if declined: After deleting an image, on clicking edit icon (within 2secs) user gets stuck in gallery edit mode and needs to force quit the app. This issue is difficult to replicate in 2.2 because of improved delete performance and can be easily replicated in build 2.1.

[Testing completed]: 2.1 and master
[Risk to taking this patch] (and alternatives if risky): none, the fix disables edit icon so that user cannot click edit right after deleting a photo and while it is still visible.

As an extra precaution, two checks whether imageEditor is defined before using it are added so that x and done buttons work and not throw error if user get stuck in edit mode with black screen.

[String changes made]: None

Comment 13

[bhavana bajaj [:bajaj]]

Requesting QA help for verifying this issue on master here.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/16b42266e44dab249784dc05af78fca6727dee90

Comment 15

[Brogan Zumwalt [Inactive]]

Issue verified fixed on Flame 2.1 and Flame 2.2

Actual Results: Edit button disabled after deleting photo. Next photo/video in Gallery almost immediately appears in place of deleted photo.

Device: Flame 2.1 (319mb)(Kitkat Base)(Shallow Flash)
BuildID: 20141104001202
Gaia: 9d80d556123553e5fd8acd982192e33807e9e1fe
Gecko: 388b03efe92d
Version: 34.0 (2.1)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.2(319mb)(KitKat)(Shallow Flash)
Build ID: 20141104040207
Gaia: 3c50520982560ccba301474d1ac43706138fc851
Gecko: 54d05732f29b
Version: 36.0a1 (2.2)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0