1088208 - Allow tooltool.py to fetch files by using an authentication file

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Armen [:armenzg]]

Attachment: tooltool.diff

This is useful for fetching files from a developer's machine.

Comment 1

[Armen [:armenzg]]

Attachment: mh.tooltool.diff

I would not land as-is; I would like the previous patch to land first.

Comment 2

[Chris AtLee [:catlee]]

Comment on attachment 8510511 [details] [diff] [review]
mh.tooltool.diff

Review of attachment 8510511 [details] [diff] [review]:
-----------------------------------------------------------------

good idea, re-work it a bit?

::: configs/developer_config.py
@@ +16,5 @@
>      "tooltool_servers": ["https://secure.pub.build.mozilla.org/tooltool/pvt/build"],
> +    "tooltool_cache": os.path.join(os.getenv("HOME"), ".mozilla/releng/builds/tooltool_cache"),
> +    "tooltool_cache_path": os.path.join(os.getenv("HOME"), ".mozilla/releng/builds/tooltool_cache"),
> +    #"tooltool_py": "https://raw.githubusercontent.com/mozilla/build-tooltool/master/tooltool.py",
> +    "tooltool_py": "http://people.mozilla.org/~armenzg/incoming/tooltool.py.txt",

I'd name this 'tooltool_py_url' or something.

::: mozharness/mozilla/tooltool.py
@@ +30,5 @@
> +                ))
> +            if not os.path.exists(file_path):
> +                self.fatal("We can't get tooltool.py")
> +            self.chmod(file_path, 0755)
> +            tooltool = [file_path]

move most of this into a separate function?

if not os.path.exists(str(tooltool))...:
   tooltool = self.fetch_remote_tooltool()

Comment 3

[Armen [:armenzg]]

Attachment: wip - [mozharness] allow running Android jobs to run locally and use authenticated tooltool

Not working yet.

Comment 4

[Armen [:armenzg]]

Attachment: [tooltool] allow for authenticated file retrievals

Comment 5

[Armen [:armenzg]]

Attachment: [mozharness] allow to run android jobs for a developer and use authenticated tooltool

A run to try will be needed to make sure nothing is regressed.

Comment 6

[Armen [:armenzg]]

Adding jlund since he is working on tooltool for desktop so he can be in the loop.
Adding gbrown since we both originally worked on the android scripts and I want him to know that developer mode is coming to this script.

Comment 7

[Armen [:armenzg]]

Comment on attachment 8536094 [details] [diff] [review]
[mozharness] allow to run android jobs for a developer and use authenticated tooltool

I will put the final patch in bug 1086672.

Comment 8

[Rail Aliiev [:rail]]

Comment on attachment 8536093 [details] [diff] [review]
[tooltool] allow for authenticated file retrievals

lgtm

Comment 9

[Armen [:armenzg]]

https://github.com/mozilla/build-tooltool/pull/1

Comment 10

[Armen [:armenzg]]

https://hg.mozilla.org/build/puppet/rev/111e26506b74

Comment 11

[Armen [:armenzg]]

You're da bomb! Thank you, thank you!