1088214 - Remove JSCLASS_IMPLEMENTS_BARRIERS

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Terrence Cole [:terrence]]

We should have complete coverage by now and we really don't want to fall off IGC if we don't. Let's just do a MOZ_RELEASE_ASSERT and fix anything else that crops up.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: bug1088214-assert-barriers-flag

Patch to do a release assert when creating an object that the class supports barriers.

I take it the eventual goal is to remove this flag entirely if we're clean with this change?

Comment 2

[Terrence Cole [:terrence]]

Comment on attachment 8550405 [details] [diff] [review]
bug1088214-assert-barriers-flag

Review of attachment 8550405 [details] [diff] [review]:
-----------------------------------------------------------------

Great! I don't expect any problems landing, but the long-tail of addons might be impacted. Let's let this ride the trains out to release and sit a cycle or two to make sure any and all Class users get converted their internals converted over to Heap<T>.

Comment 3

[Jon Coppeard (:jonco)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7730fb681bd7

Comment 4

[Tom S. (please needinfo tschuster)]

We actually expose if Incremental GC is disabled on about:support, so that is a bunch of code that could be removed.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7730fb681bd7

Comment 6

[Terrence Cole [:terrence]]

We can probably move forward with the removal now.

Comment 7

[Jon Coppeard (:jonco)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a8336e41f58

Comment 8

[Jon Coppeard (:jonco)]

Attachment: bug1088214-remove-barriers-flag

Good call.  Here's the patch.

Comment 9

[Terrence Cole [:terrence]]

Comment on attachment 8655391 [details] [diff] [review]
bug1088214-remove-barriers-flag

Review of attachment 8655391 [details] [diff] [review]:
-----------------------------------------------------------------

\o/

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c11a03fbc6b7

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c11a03fbc6b7