Closed Bug 1088214 Opened 6 years ago Closed 6 years ago

Remove JSCLASS_IMPLEMENTS_BARRIERS

Categories

(Core :: JavaScript: GC, defect)

Product:
Core
Component:
JavaScript: GC
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla43
Tracking Flags:
Tracking Status
firefox43 --- fixed

People

(Reporter: terrence, Assigned: jonco)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

bug1088214-assert-barriers-flag
3.87 KB, patch
terrence
: review+
Details | Diff | Splinter Review
bug1088214-remove-barriers-flag
44.98 KB, patch
terrence
: review+
Details | Diff | Splinter Review 
We should have complete coverage by now and we really don't want to fall off IGC if we don't. Let's just do a MOZ_RELEASE_ASSERT and fix anything else that crops up.
Assignee: nobody → jcoppeard
Patch to do a release assert when creating an object that the class supports barriers.

I take it the eventual goal is to remove this flag entirely if we're clean with this change?
Attachment #8550405 - Flags: review?(terrence)
Comment on attachment 8550405 [details] [diff] [review]
bug1088214-assert-barriers-flag

Review of attachment 8550405 [details] [diff] [review]:
-----------------------------------------------------------------

Great! I don't expect any problems landing, but the long-tail of addons might be impacted. Let's let this ride the trains out to release and sit a cycle or two to make sure any and all Class users get converted their internals converted over to Heap<T>.
Attachment #8550405 - Flags: review?(terrence) → review+
We actually expose if Incremental GC is disabled on about:support, so that is a bunch of code that could be removed.
We can probably move forward with the removal now.
Flags: needinfo?(jcoppeard)
Good call.  Here's the patch.
Flags: needinfo?(jcoppeard)
Attachment #8655391 - Flags: review?(terrence)
Comment on attachment 8655391 [details] [diff] [review]
bug1088214-remove-barriers-flag

Review of attachment 8655391 [details] [diff] [review]:
-----------------------------------------------------------------

\o/
Attachment #8655391 - Flags: review?(terrence) → review+
Keywords: leave-open
https://hg.mozilla.org/mozilla-central/rev/c11a03fbc6b7
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox43: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.