1088460 - [EME] Warning "Failed to delete GMP storage directory" during GMPStorage gtests

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

We're getting a NS_WARNING("Failed to delete GMP storage directory") when running GMPStorage gtests.

This is because we're clearing storage when storage is already clear, and the operation to delete the storage directory is failing to delete a path that doesn't exist.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

Only try to delete the GMP storage path if it exists, so we'll only warn if the GMP storage path does exist and we failed to delete it. The warning no longer fires during GMP gtests.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d06c3af1cfee

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d06c3af1cfee

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Mass update firefox-status to track EME uplift.