1088468 - [Settings] After the OMA CP is received and installed the APN is not listed until restarting the settings app

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Arthur Chen [:arthurcc][inactive after 6/30]]

As https://bugzilla.mozilla.org/show_bug.cgi?id=1079356#c20

STR:
  1. Open Settings app.
  2. Go to Cellular & Data -> SIM settings -> APN Settings -> Data Settings.
  3. See the APN list (Movistar and Jazztel Internet). 
  4. Return to main menu of settings app, andn press home button. 
  5. Wait for OMA CP message.
  6. Receive OMA CP message and accept it --> new apn profile, Telefonica 1.
  7. Open Settings app and go to Data Settings.

Actual:
  See the APN list... Telefonica 1 is not in the apn list. 

Expected:
  See the APN list... Telefonica 1 now is in the apn list.

Comment 1

[Beatriz Rodríguez [:brg]]

[Blocking Requested - why for this release]: It is a regression. It was working fine in 1.3 and 2.0.

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

Adding qawanted for branch checks.

Comment 3

[Robert Mead [:RobertM]]

I got a different result for each version. I tested this using 3 attempts for each version:


On v2.2, When I received the OMA CP message and accepted it, the new APN profile showed up in the settings menu right away.

Flame 2.2

Eronmental Variables:
Device: Flame Master (319mb)(Kitkat Base)(Full Flash)
Build ID: 20141027040237
Gaia: e91d99e4d96954f06383c00bb9d79598a697e310
Gecko: 8230834302c9
Version: 36.0a1 (Master)
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0


On v2.1, When I received the OMA CP message and accepted it, the new APN profile would not show up until I restarted the settings app.

Flame 2.1 

Environmental Variables:
Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash)
Build ID: 20141027001201
Gaia: c97463d61f45513a2123b19610386ddbfc916819
Gecko: 4f8c0c021128
Version: 34.0 (2.1)
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0


On v2.0, When I received the OMA CP message and accepted it, the new APN profile would not show up at all, even after resetting the entire device.

Flame 2.0

Device: Flame 2.0 (319mb)(Kitkat Base)(Full Flash)
Build ID: 20141027000202
Gaia: 2183b4f3ec0eb47ab1f133c31732ec53b08ad253
Gecko: 43bee45176c4
Version: 32.0 (2.0)
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 4

[howie [:howie]]

Triage: functional defect, blocking

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

I can also reproduce it on master. The apn list won't be updated once you've queried it. Mark affected on master.

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: PR against master and v2.1

EJ, could you help review the patch?

The root cause is that when the WAP push app clears the apn selection, the apn selection object in settings app should also clear its internal cache. As for v2.0, the code base regarding this part is completely different, I will submit another PR later. Thanks.

Comment 7

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8516378 [details]
PR against master and v2.1

r+ !! Thanks Arthur, we will fix the data-src problem when settings dialog got finished.

Comment 8

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to EJ Chen [:eragonj][:小龍哥][ni? if you need me] from comment #7)
> Comment on attachment 8516378 [details]
> PR against master and v2.1
> 
> r+ !! Thanks Arthur, we will fix the data-src problem when settings dialog
> got finished.

typo: this is for bug 1089572, I would check this patch later.

Comment 9

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8516378 [details]
PR against master and v2.1

this patch looks fine, r+ !

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks for reviewing.

master: 068b9711277b06c7d633517f9e1fcb5624bb39b3

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8516378 [details]
PR against master and v2.1

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 1032629
[User impact] if declined: Users have to restart settings app to see the newly added apn.
[Testing completed]: Manual and unit tests were completed.
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: N/A

Comment 12

[sarsenyev]

Verified the issue is fixed on 2.2 master Flame
A new APN is created when OMA CP recieved without restarting the "Settings" app

Device: Flame 2.2 Master KK
BuildID: 20141107040206
Gaia: 779f05fead3d009f6e7fe713ad0fea16b6f2fb31
Gecko: 64f4392d0bdc
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 36.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Adding "verifyme" for 2.1

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/afd413fc30bc2a3db2580aaf13ff8b92f4dda552

Comment 14

[sarsenyev]

Verified the issue is fixed on 2.1 Flame
A new APN is created when OMA CP recieved without restarting the "Settings" app

Device: Flame 2.1
BuildID: 20141110001201
Gaia: 0ec1925fc37b7c71d129ae44e42516a0cfb013c4
Gecko: 97487a2d1ee6
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 (2.1)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 15

[Juanjo Iglesias]

We have tested it using a flame master (Gecko 1e0235c Gaia b6ae1d6) and flame 2.1 (Gecko 8454ca1 Gaia 5c93577).

In both cases, a new APN is created when OMA CP recieved without restarting the "Settings" app