Closed Bug 1088578 Opened 5 years ago Closed 5 years ago

Replace rgba(...,0) and hsla(...,0) with 'transparent' in CSS gradients

Categories

(Firefox :: Theme, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 36

People

(Reporter: dao, Assigned: discoman, Mentored)

References

Details

(Whiteboard: [good first bug][lang=css])

Attachments

(1 file, 2 obsolete files)

As a workaround to bug 591600, we've been using code like this:

> linear-gradient(rgba(255,255,255,0.3), rgba(255,255,255,0));

instead of:

> linear-gradient(rgba(255,255,255,0.3), transparent);

Now that bug 591600 is fixed, we can use the latter.

Useful links:

http://mxr.mozilla.org/mozilla-central/search?string=%2C+rgba&find=themes&filter=0\%29

http://mxr.mozilla.org/mozilla-central/search?string=%2C+hsla&find=themes&filter=0\%29
Please can i take up this.This would be my first one to work upon.
Sure, go ahead. Let me know if you have questions.
Attached patch bug1088578.diff (obsolete) — Splinter Review
I have replaced all the hsla and rgba with alpha(a) as 0 to transparent.
Attachment #8511473 - Flags: review?(dao)
Comment on attachment 8511473 [details] [diff] [review]
bug1088578.diff

>--- a/browser/themes/linux/browser.css
>+++ b/browser/themes/linux/browser.css

> .chat-titlebar {
>   background-color: #d9d9d9;
>-  background-image: linear-gradient(@toolbarHighlight@, rgba(255,255,255,0));
>+  background-image: linear-gradient(@toolbarHighlight@,transparent);
> }

please keep the space after the comma

> .chatbar-button {
>   -moz-appearance: none;
>   background-color: #d9d9d9;
>-  background-image: linear-gradient(@toolbarHighlight@, rgba(255,255,255,0));
>+  background-image: linear-gradient(@toolbarHighlight@,transparent);
> }

ditto

>--- a/browser/themes/windows/browser.css
>+++ b/browser/themes/windows/browser.css

> #urlbar-stop-button:hover:active {
>-  background-image: radial-gradient(circle closest-side, hsla(5,100%,75%,.1), hsla(5,100%,75%,0));
>+  background-image: radial-gradient(circle closest-side, hsla(5,100%,75%,.1),transparent);
>   -moz-image-region: rect(28px, 28px, 42px, 14px);
> }

ditto

Looks good otherwise. Thanks!
Attachment #8511473 - Flags: review?(dao) → review+
Assignee: nobody → sparshpaliwal123
Attached patch bug1088578_whitespacefix.diff (obsolete) — Splinter Review
i have made the changes directly to the patch file for the white space.
Attachment #8511595 - Flags: review?(dao)
(In reply to Sparsh Paliwal from comment #5)
> Created attachment 8511595 [details] [diff] [review]
> bug1088578_whitespacefix.diff
> 
> i have made the changes directly to the patch file for the white space.

You've missed the first case (.chat-titlebar)...
Apologies for the silly mistake committed.Thanks for the help and guidance......
Comment on attachment 8511663 [details] [diff] [review]
bug1088578_whitespacefix2.diff

Thanks!
Attachment #8511663 - Flags: review+
Attachment #8511595 - Attachment is obsolete: true
Attachment #8511595 - Flags: review?(dao)
Attachment #8511473 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/3adeab7e472d
Keywords: checkin-needed
Whiteboard: [good first bug][lang=css] → [good first bug][lang=css][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/3adeab7e472d
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][lang=css][fixed-in-fx-team] → [good first bug][lang=css]
Target Milestone: --- → Firefox 36
Depends on: 1256359
You need to log in before you can comment on or make changes to this bug.