Closed Bug 1088625 Opened 5 years ago Closed 5 years ago

Pass nsFontMetrics objects through to code that needs it instead of storing it on the nsRenderingContext

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

Attachments

(2 files)

No description provided.
To be clear about part 2, code is calling SetFont(), but since nobody calls FontMetrics() any more then the SetFont() calls are useless and can also be removed.
Attachment #8511006 - Flags: review?(mstange) → review+
Attachment #8511016 - Flags: review?(mstange) → review+
I had to add a bunch of includes to allow me to remove the unnecessary includes from nsRenderingContext.h. I landed that change as a preliminary patch. Let's call this "part 1" and I'll rename the others as appropriate:

https://hg.mozilla.org/integration/mozilla-inbound/rev/6d6117a79a0e
Comment on attachment 8511006 [details] [diff] [review]
part 2 - Pass nsFontMetrics objects through to code that needs it instead of storing it on the nsRenderingContext

https://hg.mozilla.org/integration/mozilla-inbound/rev/36f87acce2f9
Attachment #8511006 - Attachment description: part 1 - Pass nsFontMetrics objects through to code that needs it instead of storing it on the nsRenderingContext → part 2 - Pass nsFontMetrics objects through to code that needs it instead of storing it on the nsRenderingContext
Attachment #8511006 - Flags: checkin+
Comment on attachment 8511016 [details] [diff] [review]
part 3 - Remove nsRenderingContext's SetFont, FontMetrics and SetTextRunRTL methods now that no one uses them any more.

https://hg.mozilla.org/integration/mozilla-inbound/rev/d0ab04870756
Attachment #8511016 - Attachment description: part 2 - Remove nsRenderingContext's SetFont, FontMetrics and SetTextRunRTL methods now that no one uses them any more. → part 3 - Remove nsRenderingContext's SetFont, FontMetrics and SetTextRunRTL methods now that no one uses them any more.
Attachment #8511016 - Flags: checkin+
(In reply to Jonathan Watt [:jwatt] from comment #4)
> I had to add a bunch of includes to allow me to remove the unnecessary
> includes from nsRenderingContext.h.

Somehow my |hg qfold| failed to work and I didn't notice, so the removal of the includes didn't happen. Pushed to make that so:

https://hg.mozilla.org/integration/mozilla-inbound/rev/b7050902ed03
You need to log in before you can comment on or make changes to this bug.