1088625 - Pass nsFontMetrics objects through to code that needs it instead of storing it on the nsRenderingContext

Status: RESOLVED FIXED

(Core :: Layout, defect)

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: part 2 - Pass nsFontMetrics objects through to code that needs it instead of storing it on the nsRenderingContext

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: part 3 - Remove nsRenderingContext's SetFont, FontMetrics and SetTextRunRTL methods now that no one uses them any more.

Comment 3

[Jonathan Watt [:jwatt]]

To be clear about part 2, code is calling SetFont(), but since nobody calls FontMetrics() any more then the SetFont() calls are useless and can also be removed.

Comment 4

[Jonathan Watt [:jwatt]]

I had to add a bunch of includes to allow me to remove the unnecessary includes from nsRenderingContext.h. I landed that change as a preliminary patch. Let's call this "part 1" and I'll rename the others as appropriate:

https://hg.mozilla.org/integration/mozilla-inbound/rev/6d6117a79a0e

Comment 5

[Jonathan Watt [:jwatt]]

Comment on attachment 8511006 [details] [diff] [review]
part 2 - Pass nsFontMetrics objects through to code that needs it instead of storing it on the nsRenderingContext

https://hg.mozilla.org/integration/mozilla-inbound/rev/36f87acce2f9

Comment 6

[Jonathan Watt [:jwatt]]

Comment on attachment 8511016 [details] [diff] [review]
part 3 - Remove nsRenderingContext's SetFont, FontMetrics and SetTextRunRTL methods now that no one uses them any more.

https://hg.mozilla.org/integration/mozilla-inbound/rev/d0ab04870756

Comment 7

[Jonathan Watt [:jwatt]]

(In reply to Jonathan Watt [:jwatt] from comment #4)
> I had to add a bunch of includes to allow me to remove the unnecessary
> includes from nsRenderingContext.h.

Somehow my |hg qfold| failed to work and I didn't notice, so the removal of the includes didn't happen. Pushed to make that so:

https://hg.mozilla.org/integration/mozilla-inbound/rev/b7050902ed03

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6d6117a79a0e
https://hg.mozilla.org/mozilla-central/rev/36f87acce2f9
https://hg.mozilla.org/mozilla-central/rev/d0ab04870756
https://hg.mozilla.org/mozilla-central/rev/b7050902ed03