Display the correct revision in https://treeherder.mozilla.org/media/revision

RESOLVED FIXED

Status

Tree Management
Treeherder: Infrastructure
P2
normal
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

Details

(Assignee)

Description

4 years ago
The file contains a stale revision, since we generate the file after rsyncing, so it won't be copied until the next prod push:
https://github.com/mozilla/treeherder-service/blob/master/deployment/update/update.py#L100

eg the current SHA in that file is:
https://github.com/mozilla/treeherder-service/commit/1b6c63084a5229907a66690ed6fafdf36028e461

Whereas the most recent prod push is:
http://treeherderadm.private.scl3.mozilla.com/chief/treeherder.prod/logs/master.1414088736

Which updated to 04e5402:
[localhost] out: Updating 1b6c630..04e5402

We should move the generation of the file prior to running the IT deploy script.

We should also probably list both the UI and service repo revisions in the file, or else have two files (depending on how the IRC bot needs to parse it).
(Assignee)

Comment 1

4 years ago
There are also some other tricks we can steal from:
https://github.com/mozilla/kitsune/blob/master/scripts/update/deploy.py
(Assignee)

Updated

4 years ago
No longer blocks: 1080757
(Assignee)

Updated

4 years ago
Component: Treeherder → Treeherder: Infrastructure
See Also: → bug 1112238
(Assignee)

Updated

4 years ago
Assignee: nobody → emorley
Status: NEW → ASSIGNED
(Assignee)

Comment 2

3 years ago
The fix for this is included in:
https://github.com/mozilla/treeherder-service/pull/405

Comment 3

3 years ago
Commits pushed to master at https://github.com/mozilla/treeherder-service

https://github.com/mozilla/treeherder-service/commit/0e67ca47a427cb2f9d44dc2716046b266f34090e
Bug 1088705 - Deploy script: Generate revision file before rsyncing it

Previously the revision file was regenerated after it had already been
rsynced to the webheads, and as such the publicly accessible file
displayed the previous revision, not the new revision.

https://github.com/mozilla/treeherder-service/commit/532429a9c49a31399c3876c9431fcc3741e4b077
Bug 1088705 - Deploy script: Make the git output less chatty

The git reset already outputs the SHA/commit message for HEAD so
most of this additional output is unnecessary.
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.