1088711 - New bugzilla users are unable to user bug templates

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Administration, task)

Description

[Jeff Beatty [:gueroJeff]]

New bugzilla users are unable to user bug templates. They are, instead, redirected to the orientation process, which doesn't pull in data from the template URL that they've clicked.

Expected outcome: New users can file bugs using a bug template, either with the orientation process or the full bug view.

Comment 1

[David Lawrence [:dkl]]

Not sure what you mean here. Are you talking about the guided bug entry form for inexperienced BMO users or are you talking about some other custom bug entry forms? Can we have an exact URL that displays what you are describing?

dkl

Comment 2

[Jeff Beatty [:gueroJeff]]

Yes, the guided entry form.

I can give you a bug template and provide steps to reproduce with a new BMO user account:

Template: https://bugzilla.mozilla.org/enter_bug.cgi?assigned_to=nobody%40mozilla.org&bug_file_loc=http%3A%2F%2F&bug_ignored=0&bug_severity=normal&bug_status=NEW&cc=lebedel.delphine%40gmail.com&cc=jbeatty%40mozilla.com&cf_blocking_b2g=---&cf_blocking_fennec=---&cf_fx_iteration=---&cf_fx_points=---&cf_status_b2g_1_4=---&cf_status_b2g_2_0=---&cf_status_b2g_2_0m=---&cf_status_b2g_2_1=---&cf_status_b2g_2_2=---&cf_status_firefox33=---&cf_status_firefox34=---&cf_status_firefox35=---&cf_status_firefox36=---&cf_status_firefox_esr31=---&cf_status_seamonkey229=---&cf_status_seamonkey230=---&cf_status_seamonkey231=---&cf_status_seamonkey232=---&cf_status_seamonkey233=---&cf_tracking_b2g=---&cf_tracking_firefox33=---&cf_tracking_firefox34=---&cf_tracking_firefox35=---&cf_tracking_firefox36=---&cf_tracking_firefox_esr31=---&cf_tracking_firefox_relnote=---&cf_tracking_relnote_b2g=---&cf_tracking_seamonkey229=---&cf_tracking_seamonkey230=---&cf_tracking_seamonkey231=---&cf_tracking_seamonkey232=---&cf_tracking_seamonkey233=---&comment=Description%20should%20contain%20the%20following%20info%3A%0D%0A%0D%0A%22This%20bug%20is%20being%20filed%20to%20report%20results%20from%20L10n%20Run%20%231%20translation%20quality%20review.%20Please%20verify%20the%20translation%20issue%20reported%20here%20and%20proceed%20to%20making%20any%20necessary%20corrections.%20For%20more%20information%20about%20the%20criteria%20used%20for%20the%20translation%20evaluation%2C%20please%20see%20the%20MQM%20standard%20http%3A%2F%2Fwww.qt21.eu%2Fmqm-definition%2Fdefinition-2014-08-19.html%20%22%0D%0A%0D%0AIssue%20type%20definition%3A%20%0D%0AIssue%20type%20error%20score%3A%20%0D%0AString%20location%28s%29%20by%20entity%3A%20%0D%0AGrader%20comments%3A%20&component=pt-BR%20%2F%20Portuguese%20%28Brazil%29&contenttypemethod=autodetect&contenttypeselection=text%2Fplain&defined_groups=1&flag_type-37=X&flag_type-4=X&flag_type-607=X&flag_type-730=X&flag_type-733=X&flag_type-746=X&flag_type-781=X&flag_type-787=X&flag_type-791=X&flag_type-800=X&flag_type-803=X&flag_type-864=X&form_name=enter_bug&maketemplate=Remember%20values%20as%20bookmarkable%20template&op_sys=Gonk%20%28Firefox%20OS%29&priority=--&product=Mozilla%20Localizations&rep_platform=ARM&short_desc=%5B2.1%5D%20%5Btranslation%5D%20%5Bissue_type%5D%20Bug%20summary%20for%20a%20specific%20string%2C%20or%20set%20of%20strings&status_whiteboard=LocRun2.1%2C%20MQM2.1&target_milestone=---&version=unspecified

Steps to reproduce:
1) New (inexperienced) BMO user logs into BMO.
2) Clicks on template link to file specific bugs.
3) Is redirected to empty guided entry form.

Expected outcome:
I would expect a template link to override the guided entry form redirect, not the other way around. I would also expect that if the guided entry from overrides the template link, that the data from the template URL would be pre-populated in the guided entry form, instead of exposing the user to a blank guided entry form.

Comment 3

[Dylan Hardison [:dylan] (he/him)]

Attachment: bug-1088711-v1.patch

For the medium term, we can detect the "maketemplate" param and force the default bug form. It will be a lot more effort to integrate pre-filled form values for the guided bug entry system.

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 8511415 [details] [diff] [review]
bug-1088711-v1.patch

Review of attachment 8511415 [details] [diff] [review]:
-----------------------------------------------------------------

Just add 'format' as a hidden form var in create.html.tmpl

diff --git a/template/en/default/bug/create/create.html.tmpl b/template/en/default/bug/create/create.html.tmpl
index 4e37e20..79b2f8d 100644
--- a/template/en/default/bug/create/create.html.tmpl
+++ b/template/en/default/bug/create/create.html.tmpl
@@ -200,6 +200,7 @@ TUI_hide_default('attachment_text_field');
 <input type="hidden" name="product" value="[% product.name FILTER html %]">
 <input type="hidden" name="token" value="[% token FILTER html %]">
 <input type="hidden" name="bug_ignored" value="[% bug_ignored ? "1" : "0" %]">
+<input type="hidden" name="format" value="[% format || '__default__' FILTER html %]">
 
 <table>
 <tbody>

Comment 5

[Dylan Hardison [:dylan] (he/him)]

That solves the problem for all future links, I thought the scope of the bug was to fix any existing links (e.g. bookmarks).

Comment 6

[David Lawrence [:dkl]]

Comment on attachment 8511415 [details] [diff] [review]
bug-1088711-v1.patch

(In reply to Dylan William Hardison [:dylan] from comment #5)
> That solves the problem for all future links, I thought the scope of the bug
> was to fix any existing links (e.g. bookmarks).

Actually scratch my suggested fix as it breaks if you click submit :( It looks for a comment-<format>.txt.tmpl file which does not exist.

r=dkl for your previous fix.

dkl

Comment 7

[Dylan Hardison [:dylan] (he/him)]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   7afb631..713077f  master -> master