Closed Bug 1088748 Opened 5 years ago Closed 5 years ago

SeaMonkey part for Add newChannel2 to nsIProtocolHandler (Bug 1067471) and Extend NewChannel() with loadinfo argument in nsIAboutModule (Bug 1067468)

Categories

(SeaMonkey :: General, defect)

defect
Not set

Tracking

(seamonkey2.33 fixed)

RESOLVED FIXED
seamonkey2.33
Tracking Status
seamonkey2.33 --- fixed

People

(Reporter: philip.chee, Assigned: philip.chee)

Details

Attachments

(1 file)

Relevant Firefox/Gecko bugs:
Bug 1067471 - Add newChannel2 to nsIProtocolHandler that takes a loadinfo as an argument
Bug 1067468 - Extend NewChannel() with loadinfo argument in nsIAboutModule
More fallout from mozilla-central. This patch may not be necessary.
Attachment #8511134 - Flags: review?(neil)
Comment on attachment 8511134 [details] [diff] [review]
Patch v1.0 Proposed fix.

I suppose at some point we'll have to do something with that new parameter...
Attachment #8511134 - Flags: review?(neil) → review+
(In reply to neil@parkwaycc.co.uk from comment #2)
> Comment on attachment 8511134 [details] [diff] [review]
> Patch v1.0 Proposed fix.
> 
> I suppose at some point we'll have to do something with that new parameter...

That appears to be the plan over in Mozilla-central.
comm-central changeset e8f0a5702a90
Pushed to comm-central http://hg.mozilla.org/comm-central/rev/e8f0a5702a90
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.33
Comment on attachment 8511134 [details] [diff] [review]
Patch v1.0 Proposed fix.

Review of attachment 8511134 [details] [diff] [review]:
-----------------------------------------------------------------

::: suite/feeds/src/FeedConverter.js
@@ +509,5 @@
>      return uri;
>    },
>  
>    newChannel: function newChannel(aUri) {
> +    return this.newChannel2(inputURI, null);

Too much copy&paste. Now selecting a feed from the feeds icon to the right of the location bar throws an error:

Error: ReferenceError: inputURI is not defined
Source File: resource://gre/components/FeedConverter.js
Line: 513
(In reply to Jens Hatlak (:InvisibleSmiley) from comment #5)
> Too much copy&paste. Now selecting a feed from the feeds icon to the right
> of the location bar throws an error:

I pushed a bustage fix to comm-central and comm-aurora
http://hg.mozilla.org/comm-central/rev/941971dc9aec
http://hg.mozilla.org/releases/comm-aurora/rev/a9f68b06d1b4
You need to log in before you can comment on or make changes to this bug.