1088748 - SeaMonkey part for Add newChannel2 to nsIProtocolHandler (Bug 1067471) and Extend NewChannel() with loadinfo argument in nsIAboutModule (Bug 1067468)

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Philip Chee]

Relevant Firefox/Gecko bugs:
Bug 1067471 - Add newChannel2 to nsIProtocolHandler that takes a loadinfo as an argument
Bug 1067468 - Extend NewChannel() with loadinfo argument in nsIAboutModule

Comment 1

[Philip Chee]

Attachment: Patch v1.0 Proposed fix.

More fallout from mozilla-central. This patch may not be necessary.

Comment 2

[[e-mail]]

Comment on attachment 8511134 [details] [diff] [review]
Patch v1.0 Proposed fix.

I suppose at some point we'll have to do something with that new parameter...

Comment 3

[Philip Chee]

(In reply to [e-mail] from comment #2)
> Comment on attachment 8511134 [details] [diff] [review]
> Patch v1.0 Proposed fix.
> 
> I suppose at some point we'll have to do something with that new parameter...

That appears to be the plan over in Mozilla-central.

Comment 4

[Philip Chee]

comm-central changeset e8f0a5702a90
Pushed to comm-central http://hg.mozilla.org/comm-central/rev/e8f0a5702a90

Comment 5

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 8511134 [details] [diff] [review]
Patch v1.0 Proposed fix.

Review of attachment 8511134 [details] [diff] [review]:
-----------------------------------------------------------------

::: suite/feeds/src/FeedConverter.js
@@ +509,5 @@
>      return uri;
>    },
>  
>    newChannel: function newChannel(aUri) {
> +    return this.newChannel2(inputURI, null);

Too much copy&paste. Now selecting a feed from the feeds icon to the right of the location bar throws an error:

Error: ReferenceError: inputURI is not defined
Source File: resource://gre/components/FeedConverter.js
Line: 513

Comment 6

[Philip Chee]

(In reply to Jens Hatlak (:InvisibleSmiley) from comment #5)
> Too much copy&paste. Now selecting a feed from the feeds icon to the right
> of the location bar throws an error:

I pushed a bustage fix to comm-central and comm-aurora
http://hg.mozilla.org/comm-central/rev/941971dc9aec
http://hg.mozilla.org/releases/comm-aurora/rev/a9f68b06d1b4