1088772 - Sending a blank line breaks OTR

Status: RESOLVED FIXED

(Instantbird Graveyard :: Conversation, defect)

Description

[arlolra]

Attachment: null.patch

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/38.0.2125.104 Safari/537.36

Steps to reproduce:

Sent a message with a blank line using the OTR extension.


Actual results:

IRC split the lines and the empty message fell back to original encrypted message when displaying the outgoing message.


Expected results:

Displayed the blank line.

Comment 1

[Florian Quèze [:florian]]

Comment on attachment 8511139 [details] [diff] [review]
null.patch

This needs a comment, otherwise someone will look at the code, clean it up with || and re-introduce the bug.

Comment 2

[arlolra]

Attachment: null.patch from comment 1

Comment 3

[Patrick Cloke [:clokep]]

Comment on attachment 8511164 [details] [diff] [review]
null.patch from comment 1

Review of attachment 8511164 [details] [diff] [review]:
-----------------------------------------------------------------

::: chat/components/src/imConversations.js
@@ +37,5 @@
> +    // Explicitly test for null so that blank messages don't fall back to
> +    // the original. Especially problematic in encryption extensions like OTR.
> +    return this._displayMessage !== null
> +      ? this._displayMessage
> +      : this.prplMessage.originalMessage;

Nit: Please put operators at the ends of lines, thanks!

Comment 4

[arlolra]

Attachment: null.patch from comment 3

Comment 5

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/comm-central/rev/6b5ab77843f5