1088835 - have marionette-socket-host kick off runner-service

Status: RESOLVED FIXED

(Testing Graveyard :: JSMarionette, defect)

Description

[Malini Das [:mdas] - Away, not checking bugmail]

This bug will move the python runner-service code to mocha-socket-host instead of in the Makefile.

Comment 1

[Malini Das [:mdas] - Away, not checking bugmail]

(In reply to Malini Das [:mdas] from comment #0)
> This bug will move the python runner-service code to mocha-socket-host
should be marionette-socket-host

Comment 2

[Malini Das [:mdas] - Away, not checking bugmail]

Related PRs:
https://github.com/mozilla-b2g/marionette-js-runner/pull/42
https://github.com/mozilla-b2g/marionette-socket-host/pull/2
https://github.com/mozilla-b2g/gaia/pull/25850

Comment 3

[Malini Das [:mdas] - Away, not checking bugmail]

all these parts have landed.

Comment 4

[Julien Wajsberg [:julienw]]

I'm sorry to remove some of the fun, but you can't just call "npm install" in the Makefile, and increase versions in package.json.

The main reason is that in TBPL we need things to come from mozilla servers only. That means we have another git repository [1] that is mirrored on git.mozilla.org. The repository in git.mozilla.org is used in TBPL, and the one in github is used otherwise.

[1] https://github.com/mozilla-b2g/gaia-node-modules

That means you can't just do what you did in that patch, because this will cause all sorts of issues.
I think we should backout and have this reviewed by a build peer (these days, it's :ricky), and I'd also like to have a feedback from :kgrandon here.

Comment 5

[Malini Das [:mdas] - Away, not checking bugmail]

(In reply to Julien Wajsberg [:julienw] from comment #4)
> I'm sorry to remove some of the fun, but you can't just call "npm install"
> in the Makefile, and increase versions in package.json.
> 
> The main reason is that in TBPL we need things to come from mozilla servers
> only. That means we have another git repository [1] that is mirrored on
> git.mozilla.org. The repository in git.mozilla.org is used in TBPL, and the
> one in github is used otherwise.
> 
> [1] https://github.com/mozilla-b2g/gaia-node-modules
> 
> That means you can't just do what you did in that patch, because this will
> cause all sorts of issues.
> I think we should backout and have this reviewed by a build peer (these
> days, it's :ricky), and I'd also like to have a feedback from :kgrandon here.

Right, but tbpl currently won't hit that part of the Makefile, since it will only install the extra packages if BUILDAPP=device, and we don't run device builds in tbpl. I've filed https://bugzilla.mozilla.org/show_bug.cgi?id=1089712 to address the case when we do want to run tests on device in tbpl (this bug is needed before we can update gaia-node-modules with the new package, since they rely on libzmq)

As for the increased package.json version, we already updated the gaia-node-modules repo with the respective changes https://github.com/mozilla-b2g/gaia-node-modules/commits/master, they were done on Nov 5.