3.43 KB, patch
|Details | Diff | Splinter Review|
I tried to do this in bug 1084001 but idlharness asserts the old spec behavior. Need to get that fixed upstream first I guess? But in practice, we want it fixed in the same changeset that removes the JSPROP_PERMANENT, so we don't have to add/remove tons of failure annotations.
And we'd want to update the web-platform-test harness here too.
Submitted the change as <https://github.com/w3c/testharness.js/pull/87>; feel free to cherry-pick that into dom/imptests/idlharness.js. I'd be fine with doing the same for the wpt copy, but that's jgraham's turf.
Flags: needinfo?(Ms2ger) → needinfo?(james)
Yeah, this is approximately the worst case for updating web-platform-tests because the idlharness.js file is in with testharness.js. I suggest that we land the change in testharness.js, update upstream web-platform-tests upstream to include the change then update locally to the revision prior to that update. Then we can make a combined patch with the gecko fix and a bump of wpt that only includes this change. Does that sound like it will work?
That sounds lovely, yes.
Created attachment 8512034 [details] [diff] [review] The Gecko and imptest patch. Still needs the wpt bit
4 years ago
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
James, can you do the bits you suggest in comment 3?
Yeah, I can do it, but I don't know quite how fast; wpt upgrades still rely on cedar which has worse turnaround times than try and I'm at GTAC/TPAC this week and PTO next. I'll try to fit it into the gaps this week though.
OK. This is probably not too urgent; the main constraint is it would be nice to fix it in the same release as bug 911142.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.