1089079 - Make the .length of interface objects configurable

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

I tried to do this in bug 1084001 but idlharness asserts the old spec behavior.  Need to get that fixed upstream first I guess?

But in practice, we want it fixed in the same changeset that removes the JSPROP_PERMANENT, so we don't have to add/remove tons of failure annotations.

Comment 1

[Boris Zbarsky [:bzbarsky]]

And we'd want to update the web-platform-test harness here too.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Submitted the change as <https://github.com/w3c/testharness.js/pull/87>; feel free to cherry-pick that into dom/imptests/idlharness.js.

I'd be fine with doing the same for the wpt copy, but that's jgraham's turf.

Comment 3

[James Graham [:jgraham]]

Yeah, this is approximately the worst case for updating web-platform-tests because the idlharness.js file is in with testharness.js.

I suggest that we land the change in testharness.js, update upstream web-platform-tests upstream to include the change then update locally to the revision prior to that update. Then we can make a combined patch with the gecko fix and a bump of wpt that only includes this change. Does that sound like it will work?

Comment 4

[Boris Zbarsky [:bzbarsky]]

That sounds lovely, yes.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: The Gecko and imptest patch. Still needs the wpt bit

Comment 6

[Boris Zbarsky [:bzbarsky]]

James, can you do the bits you suggest in comment 3?

Comment 7

[James Graham [:jgraham]]

Yeah, I can do it, but I don't know quite how fast; wpt upgrades still rely on cedar which has worse turnaround times than try and I'm at GTAC/TPAC this week and PTO next. I'll try to fit it into the gaps this week though.

Comment 8

[Boris Zbarsky [:bzbarsky]]

OK.  This is probably not too urgent; the main constraint is it would be nice to fix it in the same release as bug 911142.

Comment 9

[James Graham [:jgraham]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bb06fb2e1983

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bb06fb2e1983