1089177 - Port gfxFontMissingGlyphs to Moz2D

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: part 1 - Expose PatternFromState to help with Moz2D porting

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: part 2 - Port gfxFontMissingGlyphs to Moz2D

Comment 3

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8511529 [details] [diff] [review]
part 2 - Port gfxFontMissingGlyphs to Moz2D

Review of attachment 8511529 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxFontMissingGlyphs.cpp
@@ +164,4 @@
>              if (glyphBits & 1) {
> +                Rect r(aPt.x + x, aPt.y + y, 1, 1);
> +                MaybeSnapToDevicePixels(r, aDrawTarget, true);
> +                aDrawTarget.FillRect(r, aPattern);

Not sure how much this matters, but we could end up with seams between the rects if a transform is set (especially with opacity).

If we append the rects to a path and do a single fill then we avoid that.

Comment 4

[Jonathan Watt [:jwatt]]

Comment on attachment 8511528 [details] [diff] [review]
part 1 - Expose PatternFromState to help with Moz2D porting

https://hg.mozilla.org/integration/mozilla-inbound/rev/06c05ffe82f0

Comment 5

[Jonathan Watt [:jwatt]]

Comment on attachment 8511529 [details] [diff] [review]
part 2 - Port gfxFontMissingGlyphs to Moz2D

https://hg.mozilla.org/integration/mozilla-inbound/rev/74296d724342

Comment 6

[Jonathan Watt [:jwatt]]

(In reply to Matt Woodrow (:mattwoodrow) from comment #3)
> Not sure how much this matters, but we could end up with seams between the
> rects if a transform is set (especially with opacity).
> 
> If we append the rects to a path and do a single fill then we avoid that.

Good catch. I change the code to append the rects to a Path.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/06c05ffe82f0
https://hg.mozilla.org/mozilla-central/rev/74296d724342