1089191 - Gap below Loop panel footer due to min-height

Status: RESOLVED WORKSFORME

(Hello (Loop) :: Client, defect, P3)

Description

[Sören Hentzschel]

Attachment: screenshot.png

Please see the screenshot.

OS X 10.10 w/ HiDPI display, Firefox Nightly 2014-10-25.

Comment 1

[Tomasz Kołodziejski [:tomasz]]

The reason for that is that the panel now is even smaller. We have to decrease the number in http://hg.mozilla.org/mozilla-central/file/f2d7d694aae5/browser/modules/Social.jsm#l17 even more. In fact, we should even decrease it to some super-small universal value. And if a panel wants to be high then it should make it high by setting the height of the html inside of it. So the patch is as simple as changing that value (unless changing it breaks some other panel).

I'm not sure if this bug should really be set as blocking for bug 1069028. Especially because that bug is now fixed (and it got broken again).

Comment 2

[Matthew N. [:MattN]]

Sören, in the future, could you make the bug summary more specific please.

I think we should just lower the minimum to what Loop needs again unless mixedpuppy wants to write the patch since he knows more about the Social uses of this panel.

Follow-up bugs block the bug that caused/exposed it and bug 1069028 is what exposed this problem so this link is fine.

Comment 3

[Matthew N. [:MattN]]

This gives a bad first impression in Hello primary UI and is trivial to fix so I think we should do it. We can just bump the number from http://hg.mozilla.org/mozilla-central/file/f2d7d694aae5/browser/modules/Social.jsm#l17 down the minimal amount (to avoid risk).

Comment 4

[:shell escalante]

validate if 10/24 is before the footerbug landed - check it out.

Comment 6

[Maire Reavy [:mreavy]]

Moving P2->P3 (P3 is a "normal" bug that we want fixed for Fx36.)

Comment 7

[Mark Banner (:standard8)]

I believe this is fine from 37 onwards - there's still possibly a small line in 35/36.

I'm going to mark as WFM, if anyone thinks there's still an issue, please feel free to re-open and attach a screenshot.