1089201 - Fix for the Error: Failure in lookupFormat('cmdStatus2') when running the command cmd refresh

Status: RESOLVED FIXED

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

Description

[Collin Richards]

Attachment: the patch for this bug

To replicate open the developer toolbar and run the command cmd refresh.

It should reload the mozcmd directory set in devtools.commands.dir. However it displays the following error message:

Error: Failure in lookupFormat('cmdStatus2')

I have discovered where the error is and have attached a patch. It was as simple as the string identifier that it was referencing was misnamed.

This is my first contribution to Mozilla so if you could give me tips for getting more involved and on the standard operating procedures that would be appreciated.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Joe, more guidance may be needed here on next steps since this is their first contribution.

Comment 2

[Collin Richards]

Yeah a little more instruction would be appreciated. Am I able push directly to the fx-team branch or does the process have to go through one of you? Also this page https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F recomends having commit messages with the bug number in it. I made the commit before I filed the bug report so I'm unsure how to fix the message (it is no longer my last commit so I don't think I can do hg commit --amend).

Comment 3

[Collin Richards]

This never got added into the source tree. I need to know what to do to get the patch in. This would be my first contribution.

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Sorry, it looks like this one fell through the cracks a bit. :(

In any case, I've sent your patch to our Try testing system.  Assuming it looks good, we'll mark the bug to have patch checked in.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4b505a75e2e1

Comment 5

[Collin Richards]

(In reply to J. Ryan Stinnett [:jryans] from comment #4)
> Sorry, it looks like this one fell through the cracks a bit. :(
> 
> In any case, I've sent your patch to our Try testing system.  Assuming it
> looks good, we'll mark the bug to have patch checked in.
> 
> Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4b505a75e2e1

Alright thanks. I'll give a couple other easy bugs a shot to see if I can get the hang of the development process. If the patch is approved what is the process to get it checked in?

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Collin Richards from comment #5)
> (In reply to J. Ryan Stinnett [:jryans] from comment #4)
> > Sorry, it looks like this one fell through the cracks a bit. :(
> > 
> > In any case, I've sent your patch to our Try testing system.  Assuming it
> > looks good, we'll mark the bug to have patch checked in.
> > 
> > Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4b505a75e2e1
> 
> Alright thanks. I'll give a couple other easy bugs a shot to see if I can
> get the hang of the development process. If the patch is approved what is
> the process to get it checked in?

Great!  Most people, especially those without commit access, rely on our "sheriffs" to check in patches.  So, once the tests look good, we set the keyword "checkin-needed" on this bug, and they will land the patch for us.

One of the tests had some intermittent failures, so I am re-running to see if it clears up.

Comment 7

[Collin Richards]

(In reply to J. Ryan Stinnett [:jryans] from comment #6)
> (In reply to Collin Richards from comment #5)
> > (In reply to J. Ryan Stinnett [:jryans] from comment #4)
> > > Sorry, it looks like this one fell through the cracks a bit. :(
> > > 
> > > In any case, I've sent your patch to our Try testing system.  Assuming it
> > > looks good, we'll mark the bug to have patch checked in.
> > > 
> > > Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4b505a75e2e1
> > 
> > Alright thanks. I'll give a couple other easy bugs a shot to see if I can
> > get the hang of the development process. If the patch is approved what is
> > the process to get it checked in?
> 
> Great!  Most people, especially those without commit access, rely on our
> "sheriffs" to check in patches.  So, once the tests look good, we set the
> keyword "checkin-needed" on this bug, and they will land the patch for us.
> 
> One of the tests had some intermittent failures, so I am re-running to see
> if it clears up.

That's odd that a test is failing. Would I be able to access the second set of
tests from the same link, or is it a different link?

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Collin Richards from comment #7)
> (In reply to J. Ryan Stinnett [:jryans] from comment #6)
> > One of the tests had some intermittent failures, so I am re-running to see
> > if it clears up.
> 
> That's odd that a test is failing. Would I be able to access the second set
> of
> tests from the same link, or is it a different link?

It's unfortunately not that odd for our code base... :/ It's quite a complex project and there are many reasons why a test might fail intermittently.

Anyway, my guess is that your code is fine, but we'll know soon.

The extra test runs are shown at the same link, next to the orange "oth" there are two gray ones which are still running.

Comment 9

[Collin Richards]

Alright thanks Ryan? I've been looking for someone to help me with getting started in contributing.
Would you be willing to help me out with a mentor bug / easy bug? I can go on irc if you would like to
talk more.

Comment 10

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Collin Richards from comment #9)
> Alright thanks Ryan? I've been looking for someone to help me with getting
> started in contributing.
> Would you be willing to help me out with a mentor bug / easy bug? I can go
> on irc if you would like to
> talk more.

Our team has a hacking guide[1] to get started with the code base.

There is a list of good first bugs[2] and more general mentored bugs that could be more challenging[3].  Take a look at those and see if something interests you!  Certainly feel free to stop by #devtools on IRC as well!

[1]: https://wiki.mozilla.org/DevTools/Hacking
[2]: http://mzl.la/1AcYOKF
[3]: http://mzl.la/1pqY2q8

Comment 11

[Collin Richards]

It appears that the repeat tests have past. Should I add checkin-needed to the keywords?

Comment 12

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Collin Richards from comment #11)
> It appears that the repeat tests have past. Should I add checkin-needed to
> the keywords?

Yes, please go ahead!

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/d44daa2e0693

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d44daa2e0693