1089221 - "ICE Contacts" in contacts list is hardcoded

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Théo Chevalier]

"ICE Contacts" displayed in the main view of Contacts app is hardcoded.

It's displayed when user sets ICE Contacts from Contacts settings.

I propose we add a new string for 2.2 and reuse ICE Contacts string from Settings header for 2.1. Reusing strings is bad, but it's still better than having the first contact in English for all locales.

[Blocking Requested - why for this release]:
We have a quite visible hardcoded string in the UI, and a trivial fix to bypass it, without breaking the string freeze.

Comment 1

[Théo Chevalier]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25515

Fix for master only

Comment 2

[Théo Chevalier]

Attachment: Screenshot, Flame 2.2 (de)

Comment 3

[Théo Chevalier]

Attachment: [2.1] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25516

PR for 2.1 branch only

Both patches tested on Flame 2.2

Comment 4

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: ICE contact is major new feature for 2.1

Comment 5

[Jose Manuel Cantera]

Comment on attachment 8511558 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25515

please address comments on GH

Comment 6

[Théo Chevalier]

Comment on attachment 8511558 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25515

Thanks for the feedback, addressed your comments on both patches.
Would you mind giving it another look? :)

Thanks!

Comment 7

[Jose Manuel Cantera]

Comment on attachment 8511558 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25515

thanks Theo

Comment 8

[Jose Manuel Cantera]

Comment on attachment 8511566 [details] [review]
[2.1] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25516

thanks. good idea to reuse that string

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Landed on master:

https://github.com/mozilla-b2g/gaia/commit/2ffcbac5489f4943300e57f4d7b711bc4a1db5ab

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8511566 [details] [review]
[2.1] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25516

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Feature ice contacts
[User impact] if declined:
Bad user experience with untranslated string
[Testing completed]:
Smoke tests on the device
[Risk to taking this patch] (and alternatives if risky):
Low, just using mozl10n
[String changes made]:
No, despite is a problem with translation, we had the translation but we were not using it

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8511566 [details] [review]
[2.1] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25516

Linter failures:
https://treeherder.mozilla.org/ui/logviewer.html#?job_id=256718&repo=gaia-try

Comment 12

[Théo Chevalier]

That's really embarrassing, I forgot a semicolon in a one liner patch… Sorry guys, just fixed the PR.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/30e741b09df4800224d3360ee3be6938f5a836e3

Comment 14

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.1.

Result: "ICE Contacts" string is translated on the main screen and settings page on Contacts app when the language is set to German. 

Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141104001202
Gaia: 8b0cf889ae0d48a9eb7ecdcb9b67590de45cc5e5
Gecko: 388b03efe92d
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
=============================================

This issue still reproduces on Flame 2.2.

Result: "ICE Contacts" string is translated on the settings page on Contacts app, but NOT on the main screen when the language is set to German. (Same as the screenshot on Comment 2)

Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141104040207
Gaia: 3c50520982560ccba301474d1ac43706138fc851
Gecko: 54d05732f29b
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 36.0a1 (2.2) 
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Comment 15

[Théo Chevalier]

Hi,

Could you please check again master with pseudo-locale (Accented English) or Italian, please?

A different string is used on master, and it's not translated in German yet: http://transvision.mozfr.org/?recherche=apps%2Fcommunications%2Fcontacts%2Fcontacts.properties%3AICEContactsGroup&repo=gaia&sourcelocale=en-US&locale=de&search_type=entities

See the locales that translated this string: http://transvision.mozfr.org/string/?entity=apps/communications/contacts/contacts.properties:ICEContactsGroup&repo=gaia

Thanks!

Comment 16

[Yeojin Chung [:YeojinC]]

Hi Theo,

Thanks for the clarification. I checked with Italian and Danish, and they are both translated on master. I'll change the status to "verified" for 2.2.