Closed Bug 1089236 Opened 7 years ago Closed 6 years ago

TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-panel.testPanelDoesNotShowInPrivateWindowNoAnchor | Test output exceeded timeout (300s).

Categories

(Add-on SDK Graveyard :: General, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: evold, Unassigned)

References

()

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

TEST-PASS | addon-sdk/tests/test-panel.testPanelDoesNotShowInPrivateWindowNoAnchor | opened window is private

TEST-PASS | addon-sdk/tests/test-panel.testPanelDoesNotShowInPrivateWindowNoAnchor | private window was focused

TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-panel.testPanelDoesNotShowInPrivateWindowNoAnchor | Test output exceeded timeout (300s).

Error Cleaning up: [Error 5] Access is denied: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmppisajf.mozrunner\\sdk-fixture-chmod'

Error Cleaning up: [Error 145] The directory is not empty: 'c:\\users\\cltbld\\appdata\\local\\temp\\tmppisajf.mozrunner'

Traceback (most recent call last):

  File "bin/cfx", line 33, in <module>

    cuddlefish.run()

  File "C:\slave\test\addonsdk-poller\addon-sdk-7188743466970c82be1edc7c41112018f5311251\python-lib\cuddlefish\__init__.py", line 633, in run

    test_all(env_root, defaults=options.__dict__)

  File "C:\slave\test\addonsdk-poller\addon-sdk-7188743466970c82be1edc7c41112018f5311251\python-lib\cuddlefish\__init__.py", line 410, in test_all

    test_all_packages(env_root, defaults)

  File "C:\slave\test\addonsdk-poller\addon-sdk-7188743466970c82be1edc7c41112018f5311251\python-lib\cuddlefish\__init__.py", line 510, in test_all_packages

    env_root=env_root)

  File "C:\slave\test\addonsdk-poller\addon-sdk-7188743466970c82be1edc7c41112018f5311251\python-lib\cuddlefish\__init__.py", line 956, in run

    no_connections=no_connections)

  File "C:\slave\test\addonsdk-poller\addon-sdk-7188743466970c82be1edc7c41112018f5311251\python-lib\cuddlefish\runner.py", line 737, in run_app

    OUTPUT_TIMEOUT, test_name, parseable)

Exception: Test output exceeded timeout (300s).

TinderboxPrint:Jetpack<br/>1106/0

program finished with exit code 1
elapsedTime=771.380000
========= Finished 'python scripts/buildfarm/utils/run_jetpack.py ...' warnings (results: 1, elapsed: 12 mins, 51 secs) (at 2014-10-25 13:13:43.301071) =========
Priority: -- → P1
I don't think this will make a difference, but it might provide some more information, plus the test is at least easier to read this way.
Attachment #8514498 - Flags: review?(tomica+amo)
Assignee: nobody → evold
Comment on attachment 8514498 [details] [review]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1692

this still crashes, so i investigated some:

a) the crash happens on the second showing of the panel (first explicit call to .show())
https://github.com/mozilla/addon-sdk/pull/1692/files#diff-8e42f629d20a987b0694af6c885ff02fR710

b) it crashes later, but it's caused by .appendChild() call on #mainPopupSet
https://github.com/mozilla/addon-sdk/blob/master/lib/sdk/panel/utils.js#L332

c) now here is where it gets interesting: your (new) comment says that that line should not do anything (which was hard to understand before).  i'm gonna guess that's because Panel is not supposed to show up on a private window (by default). i tried to track down the code that decides that, as it was obviously not working, and realized we now have (at least) two problems:

1) the only panel-related code that deals with private windows is panel/window::getWindow(), and it's not used anywhere.
https://github.com/mozilla/addon-sdk/blob/master/lib/sdk/panel/window.js#L19

2) these tests are probably bogus since they didn't catch the bug whenever that code was changed. the problem is that this should be an `assert`, and not an `if`:
https://github.com/mozilla/addon-sdk/pull/1692/files#diff-8e42f629d20a987b0694af6c885ff02fR702

and i think this testing .isShowing right after calling .show() might be wrong, since that's probably an async operation:
https://github.com/mozilla/addon-sdk/pull/1692/files#diff-8e42f629d20a987b0694af6c885ff02fR712


and maybe still:

3) whether all of the above turns out right or worng, it still looks like that shouldn't crash firefox.. :\
Attachment #8514498 - Flags: review?(tomica+amo) → review-
It looks like https://github.com/mozilla/addon-sdk/pull/928 from bug 816257 caused a regression, but the tests we have did not catch it perhaps?  I'll look into that.  Also it made panel/window obsolete so we should remove that or use it again.
So the tests at https://github.com/mozilla/addon-sdk/blame/master/test/test-panel.js#L678-L786 need to be rewritten because they didn't catch a regression I suspect, when panels where detraited in https://github.com/mozilla/addon-sdk/commit/5536d4235df0779349f1a19065b00775aeb38573 and panel.js probably needs to be updated too.
Assignee: evold → nobody
(In reply to Erik Vold [:erikvold] (please needinfo? me) from comment #11)
> So the tests at
> https://github.com/mozilla/addon-sdk/blame/master/test/test-panel.js#L678-
> L786 need to be rewritten because they didn't catch a regression I suspect,
> when panels where detraited in
> https://github.com/mozilla/addon-sdk/commit/
> 5536d4235df0779349f1a19065b00775aeb38573 and panel.js probably needs to be
> updated too.

well they caught the regression it appears, just not soon enough..  the crashes are probably due to a race condition caused when calling `panel.show(null, x);panel.show(null, y)`, possibly only when x is private and y is not (so that the panel is being quickly moved).
Irakli can you take a look at this one? first I'm not sure if the regression was intentional or not, so I don't know how the test should be changed, or if panel.js needs updating.
Flags: needinfo?(rFobic)
Any reason not to disable this test in the meantime so we can get the tree greener?
Flags: needinfo?(evold)
(In reply to Dave Townsend [:mossop] from comment #14)
> Any reason not to disable this test in the meantime so we can get the tree
> greener?

That seems fine to me.
Flags: needinfo?(evold)
No longer blocks: 1083327
I'm going to look into it once I'll get more time.
Flags: needinfo?(rFobic)
Inactive; closing (see bug 1180138).
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.