1089298 - Stop mime decoding to UTF-8 only to convert to UTF-16

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Joshua Cranmer [:jcranmer]]

Let's kill this pattern:
nsAutoCString stringToMatch;
nsresult rv = mimeConverter->DecodeMimeHeaderToUTF8(
    rfc2047string, charset, charsetOverride, false, stringToMatch);

nsAutoString utf16String;
CopyUTF8toUTF16(stringToMatch, utf16String);

Comment 1

[Robert Kaiser]

After bug 998392, a lot of the strings inside JS are stored in latin1 instead of UTF16, does that play into this at all?

Comment 2

[Joshua Cranmer [:jcranmer]]

(In reply to Robert Kaiser (:[e-mail]) from comment #1)
> After bug 998392, a lot of the strings inside JS are stored in latin1
> instead of UTF16, does that play into this at all?

AUTF8String is still a nasty conversion, because it's neither UTF-16 nor Latin1.

Comment 3

[Joshua Cranmer [:jcranmer]]

Attachment: Part 1: Pass UTF-16 strings around search instead of UTF-8

Comment 4

[Joshua Cranmer [:jcranmer]]

Attachment: Part 2: Save the needle as a UTF-16 string

Comment 5

[Kent James (:rkent)]

Comment on attachment 8559275 [details] [diff] [review]
Part 2: Save the needle as a UTF-16 string

Review of attachment 8559275 [details] [diff] [review]:
-----------------------------------------------------------------

1) I believe that you also need to initialize mValue.utf16String in nsMsgSearchValueImpl::nsMsgSearchValueImpl(nsMsgSearchValue *aInitialValue)

2) Can't you use utf16String in nsMsgSearchValueImpl::GetStr(nsAString &aResult) to eliminate that conversion?

Comment 6

[Kent James (:rkent)]

Comment on attachment 8559274 [details] [diff] [review]
Part 1: Pass UTF-16 strings around search instead of UTF-8

Review of attachment 8559274 [details] [diff] [review]:
-----------------------------------------------------------------

I have my doubts as to whether this is worth the effort, but let's try it.

Comment 7

[Joshua Cranmer [:jcranmer]]

https://hg.mozilla.org/comm-central/rev/1028fda75e9d
https://hg.mozilla.org/comm-central/rev/4255fc99c7cf