Downloads button keeps attention flag after DownloadList.removeFinished() is called




Downloads Panel
3 years ago
3 years ago


(Reporter: Daniel B., Unassigned)


33 Branch
Windows 8.1

Firefox Tracking Flags

(Not tracked)



(1 attachment)



3 years ago
Created attachment 8511633 [details]
Add-on that calls removeFinished() on button click.

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0
Build ID: 20140923175406

Steps to reproduce:

With Downloads.jsm, execute the following code after a download has finished and the Downloads button in the toolbar has the attention flag set:

let downloadList = yield Downloads.getList(Downloads.ALL);

Actual results:

Download is removed (ie. list of downloads is empty). Attention flag stays.

Expected results:

Download is removed. Because there is no longer anything there warranting the attention flag, it should be removed.

Comment 1

3 years ago
Also occurs on Firefox 33, missed the update until now, sorry.
Version: 32 Branch → 33 Branch


3 years ago
Component: Untriaged → Downloads Panel

Comment 2

3 years ago
Does it work as expected in previous versions of Firefox?

Comment 3

3 years ago

In Firefox 20, the first version to fix bug 812813, this behavior can be reproduced by having the Download history open prior to finishing the download and then clearing it from there. The button will stay colored.

In Firefox 26, the first version to implement Downloads.jsm, this behavior can be reproduced the same way.

Until bug 1068052 is fixed, I expect it to remain this way. The patch on this bug report, however, will not fix this issue, because it's implement such that the state is reset "manually" after removeFinished() is called.

Comment 4

3 years ago
In the last paragraph, I meant to reference bug 974718.
You need to log in before you can comment on or make changes to this bug.