Closed Bug 1089376 Opened 5 years ago Closed 5 years ago

clicking webcompat "Report Site Issue" from private tab opens in regular tab

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 36
Tracking Status
firefox35 --- unaffected
firefox36 + verified
fennec 36+ ---

People

(Reporter: c.ascheberg, Assigned: miketaylr)

References

Details

Attachments

(1 file, 1 obsolete file)

STR:
- open website in private tab
- click "Report Site Issue" from menu

Result:
- webcompat opens in regular tab, has the "private" URL as a parameter

Expected:
- should probably open in a private tab
[Tracking Requested - why for this release]: we should keep the user's tab context
tracking-fennec: --- → ?
Assignee: nobody → miket
Yeah, that's not good. Thanks for the report Christian.
Attached patch 1089376.patch (obsolete) — Splinter Review
Comment on attachment 8512068 [details] [diff] [review]
1089376.patch

Review of attachment 8512068 [details] [diff] [review]:
-----------------------------------------------------------------

wesj is on PTO, but this looks good to me, so I think you should land it :)

::: mobile/android/chrome/content/WebcompatReporter.js
@@ +81,5 @@
>      webcompatURL.searchParams.append("url", url);
> +    if (PrivateBrowsingUtils.isBrowserPrivate(BrowserApp.selectedTab.browser)) {
> +      BrowserApp.addTab(webcompatURL.href, {isPrivate: true});
> +    } else {
> +      BrowserApp.addTab(webcompatURL.href);

While you're here, you could also set the parentId on the new tab to be the current tab, so that if the user hits back to close the tab, they'll return to the original page. Here's an example:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#546
Attachment #8512068 - Flags: review?(wjohnston) → review+
(In reply to :Margaret Leibovic from comment #4)
> While you're here, you could also set the parentId on the new tab to be the
> current tab, so that if the user hits back to close the tab, they'll return
> to the original page. Here's an example:
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/
> browser.js#546

Ah, cool. Thanks! Will update.
Attached patch 1089376-2.patchSplinter Review
Attachment #8512068 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9d42e896570c
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
tracking-fennec: ? → 36+
Clicking  "Report Site Issue" from private tab opens also in private tab, so:
verified fixed on:
device: LG Nexus 4 (Android 4.4)
build: Firefox for Android 36.0a1 (2014-10-29)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.