1089376 - clicking webcompat "Report Site Issue" from private tab opens in regular tab

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Christian Ascheberg]

STR:
- open website in private tab
- click "Report Site Issue" from menu

Result:
- webcompat opens in regular tab, has the "private" URL as a parameter

Expected:
- should probably open in a private tab

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

[Tracking Requested - why for this release]: we should keep the user's tab context

Comment 2

[Mike Taylor [:miketaylr]]

Yeah, that's not good. Thanks for the report Christian.

Comment 3

[Mike Taylor [:miketaylr]]

Attachment: 1089376.patch

Comment 4

[:Margaret Leibovic]

Comment on attachment 8512068 [details] [diff] [review]
1089376.patch

Review of attachment 8512068 [details] [diff] [review]:
-----------------------------------------------------------------

wesj is on PTO, but this looks good to me, so I think you should land it :)

::: mobile/android/chrome/content/WebcompatReporter.js
@@ +81,5 @@
>      webcompatURL.searchParams.append("url", url);
> +    if (PrivateBrowsingUtils.isBrowserPrivate(BrowserApp.selectedTab.browser)) {
> +      BrowserApp.addTab(webcompatURL.href, {isPrivate: true});
> +    } else {
> +      BrowserApp.addTab(webcompatURL.href);

While you're here, you could also set the parentId on the new tab to be the current tab, so that if the user hits back to close the tab, they'll return to the original page. Here's an example:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#546

Comment 5

[Mike Taylor [:miketaylr]]

(In reply to :Margaret Leibovic from comment #4)
> While you're here, you could also set the parentId on the new tab to be the
> current tab, so that if the user hits back to close the tab, they'll return
> to the original page. Here's an example:
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/
> browser.js#546

Ah, cool. Thanks! Will update.

Comment 6

[Mike Taylor [:miketaylr]]

Attachment: 1089376-2.patch

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/9d42e896570c

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9d42e896570c

Comment 9

[Teodora Vermesan (:TeoVermesan)]

Clicking  "Report Site Issue" from private tab opens also in private tab, so:
verified fixed on:
device: LG Nexus 4 (Android 4.4)
build: Firefox for Android 36.0a1 (2014-10-29)