1089421 - Forget button should call more attention to it closing all tabs/windows

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

Feedback from a few people (employee testing) trying the Forget button includes the suggestion that it should call greater attention to the fact that it closes all windows and tabs.

If we want to do something here, our options for 33.1 are limited due to schedule and string-freeze. But possibility would be to reorder the list, so that the bit about closing windows/tabs it at the top.

Patch is trivial, just need UX to decide if we want to do this, do something else, or ship as-is. :)

Comment 1

[Justin Dolske [:Dolske]]

Attachment: Screenshot: before

Comment 2

[Justin Dolske [:Dolske]]

Attachment: Screenshot: after

Comment 3

[:Gijs (he/him)]

Comment on attachment 8511705 [details] [diff] [review]
Patch v.1

rs=me for the code here, but this needs ui-review to land.

Comment 4

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Comment on attachment 8511705 [details] [diff] [review]
Patch v.1

Looks good.
I can't tell without testing that it would improve things, but it likely won't make anything worse, so let's roll with it :)

Comment 5

[Justin Dolske [:Dolske]]

https://hg.mozilla.org/projects/alder/rev/e0d4cbcae717

Comment 6

[Justin Dolske [:Dolske]]

https://hg.mozilla.org/integration/fx-team/rev/7b93cd7127a5

Comment 7

[Justin Dolske [:Dolske]]

Comment on attachment 8511705 [details] [diff] [review]
Patch v.1

[Triage Comment]

Comment 8

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/1047db8769ae

Comment 9

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/releases/mozilla-beta/rev/a42b0af72449

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7b93cd7127a5

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/e0d4cbcae717

Comment 12

[Bogdan Maris, Desktop Test Engineering]

Verified that 'Closing all tabs/windows' is the first information provided in Forget pop-up on Windows 7 64 bit, Mac OS X 10.8.5 and Ubuntu 12.04 32bit using latest Alder build, latest Aurora and latest Nightly.

Comment 13

[Vasilica Tamas, QA [:vtamas]]

I was able to reproduce this bug on Nightly 36.0a1 (2014-10-26) using Windows 7 x64.

Verified fixed on Windows 7 x64, Mac OSX 10.8.5 and Ubuntu 14.04 x32 using Beta 34.0b7 (20141106201515.)