Forget button should call more attention to it closing all tabs/windows

VERIFIED FIXED in Firefox 33

Status

()

defect
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: Dolske, Assigned: Dolske)

Tracking

unspecified
Firefox 36
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox33 verified, firefox34 verified, firefox35 verified, firefox36 verified)

Details

Attachments

(3 attachments)

Assignee

Description

5 years ago
Posted patch Patch v.1Splinter Review
Feedback from a few people (employee testing) trying the Forget button includes the suggestion that it should call greater attention to the fact that it closes all windows and tabs.

If we want to do something here, our options for 33.1 are limited due to schedule and string-freeze. But possibility would be to reorder the list, so that the bit about closing windows/tabs it at the top.

Patch is trivial, just need UX to decide if we want to do this, do something else, or ship as-is. :)
Attachment #8511705 - Flags: ui-review?(philipp)
Assignee

Comment 1

5 years ago
Posted image Screenshot: before
Assignee: nobody → dolske
Assignee

Comment 2

5 years ago
Posted image Screenshot: after

Comment 3

5 years ago
Comment on attachment 8511705 [details] [diff] [review]
Patch v.1

rs=me for the code here, but this needs ui-review to land.
Attachment #8511705 - Flags: review+
Comment on attachment 8511705 [details] [diff] [review]
Patch v.1

Looks good.
I can't tell without testing that it would improve things, but it likely won't make anything worse, so let's roll with it :)
Attachment #8511705 - Flags: ui-review?(philipp) → ui-review+
Assignee

Updated

5 years ago
Summary: Forget button should call more attention to it closing all tabs/windows? → Forget button should call more attention to it closing all tabs/windows
Assignee

Comment 7

5 years ago
Comment on attachment 8511705 [details] [diff] [review]
Patch v.1

[Triage Comment]
Attachment #8511705 - Flags: approval-mozilla-beta+
Attachment #8511705 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/7b93cd7127a5
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Verified that 'Closing all tabs/windows' is the first information provided in Forget pop-up on Windows 7 64 bit, Mac OS X 10.8.5 and Ubuntu 12.04 32bit using latest Alder build, latest Aurora and latest Nightly.
Flags: qe-verify+
I was able to reproduce this bug on Nightly 36.0a1 (2014-10-26) using Windows 7 x64.

Verified fixed on Windows 7 x64, Mac OSX 10.8.5 and Ubuntu 14.04 x32 using Beta 34.0b7 (20141106201515.)
You need to log in before you can comment on or make changes to this bug.