1089451 - Swiping down from top edge when utility tray is already open and it closes; quite opposite from gesture's movement

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P1)

Description

[Eric Chang [:ericcc] [:echang]]

*** Build Information
Gaia-Rev        0f76e0baac733cca56d0140e954c5f446ebc061f
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/7d78ff7d25b6
Build-ID        20141023161200
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141023.194921
FW-Date         Thu Oct 23 19:49:35 EDT 2014
Bootloader      L1TC00011880
Base image: ***Please update this field to say if you're running the v180 or the v188 base image***


*** Description
Swiping down from top edge when utility tray is already open and it closes; quite opposite from gesture's movement

*** Steps to Reproduce
1. Turning on the utility tray
2. When it is open, swiping down again
3. Utility tray closed

*** Expected Results
?

*** Actual Results
3. Utility tray closed


*** Reproduction Frequency: 100%

Comment 1

[Tony Chung [:tchung]]

sounds like by honky design.  ni? UX for proper behavior.

Comment 2

[Aus Lacroix [:aus]]

[Blocking Requested - why for this release]: This kind of thing just makes the product look bad and feel less solid. It should be an easy fix. Flagging gmarty.

Hi Tony,

I checked with UX and we're all in agreement. When swiping down again with the tray open, it should remain in it's open state.

Comment 3

[Gregor Wagner [:gwagner]]

Lets ask for uplift if we have a patch. It's not severe enough to hold the release for it.

Comment 4

[Guillaume Marty [:gmarty]]

Attachment: Github PR

This patch contains a fix and marionette tests for this + the basic gestures of the utility tray.
Etienne, can you please review it when you get a chance?

Comment 5

[Etienne Segonzac (:etienne)]

Comment on attachment 8514420 [details] [review]
Github PR

Some comments about testing that will require a quick second review round, but glad we're fixing this and kudos on the marionette test :)

Comment 6

[Guillaume Marty [:gmarty]]

Comment on attachment 8514420 [details] [review]
Github PR

Updated patch with unit test and polished marionette tests.
Etienne, I addressed your comments left on Github.

Comment 7

[Etienne Segonzac (:etienne)]

Comment on attachment 8514420 [details] [review]
Github PR

thanks!

Comment 8

[Guillaume Marty [:gmarty]]

Landed in https://github.com/mozilla-b2g/gaia/commit/7a8c0fe5bd812d51cf9dd336232b803151780171

Comment 9

[Guillaume Marty [:gmarty]]

Comment on attachment 8514420 [details] [review]
Github PR

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Utility tray
[User impact] if declined: This patch gives a better UX by making the utility tray gesture more intuitive to the user.
[Testing completed]: There is a unit and integration tests in addition to manual testing
[Risk to taking this patch] (and alternatives if risky): Very low as it's a one-liner change + heavily tested
[String changes made]: None

Comment 10

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/db7cf6079a8aec728c463151fc57d65ae946ebe4

Comment 11

[Brogan Zumwalt [Inactive]]

Issue verified fixed on Flame 2.1 and Flame 2.2

Actual Result: Swiping down while the utility tray is open does not close tray.

Device: Flame 2.1 (319mb)(Kitkat Base)(Shallow Flash)
BuildID: 20141105001204
Gaia: 1ca22badfae2f9ce066c2405af3e85c4e2d5d380
Gecko: 3b0c3580a58d
Version: 34.0 (2.1)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.2 (319mb)(KitKat)(Shallow Flash)
BuildID: 20141105040206
Gaia: 7c9e7cabbde941b976e0e40a3a1d94e21aa9c5e9
Gecko: 62990ec7ad78
Version: 36.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Leaving verifyme keyword as 2.0 is still affected.