1089529 - Lockscreen error after screen off and on when device shows NFC shrinking UI

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Alison Shiue]

*** Build Information
Gaia-Rev        0f76e0baac733cca56d0140e954c5f446ebc061f
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/7d78ff7d25b6
Build-ID        20141023161200
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141023.194921
FW-Date         Thu Oct 23 19:49:35 EDT 2014
Bootloader      L1TC00011880
Base image: v188 base image


*** Description
Lockscreen error after screen off and on when device shows NFC shrinking UI

*** Steps to Reproduce
1. 2 devices enable NFC and enable screen lock
2. Device A open an URL
3. Tap 2 phones together
4. When device A shows shrinking UI, screen off device A
5. Screen on device
6. Rotate device and check the lock screen

*** Expected Results
1. Lock screen could not be rotated

*** Actual Results
1. Lock screen error, please refer: http://youtu.be/RCELrn_TTVw

*** Reproduction Frequency: 100%

Comment 1

[Tony Chung [:tchung]]

[Blocking Requested - why for this release]:

nice bug.  this unlocked the orientation lock of lockscreen via the NFC/power off steps.

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

Adding qawanted for branch checks.

Comment 3

[Pi Wei Cheng [:piwei] (inactive)]

Issue is reproducible on Flame 2.2, Flame 2.1, Flame 2.0, and Flame base v188-1 (v2.0) only.

Observed behavior: Orientation on lockscreen can be rotated to horizontal after following STR. One minor UI difference - On 2.0 and 2.2 the lockscreen can be rotated fully without seeing the website beneath the lockscreen (as demonstrated by reporter's video), but user still can't unlock the device in horizontal orientation.

Device: Flame 2.2 Master
BuildID: 20141105120748
Gaia: 7918024c737c4570cacd784f267e28737ae05dea
Gecko: b6cd2dd85b26
Version: 36.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Device: Flame 2.1
BuildID: 20141105132045
Gaia: 1ca22badfae2f9ce066c2405af3e85c4e2d5d380
Gecko: 1b076c5a760c
Version: 34.0 (2.1)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.0
BuildID: 20141105135049
Gaia: 5ee26701a4d8db266bfb203b2179f686ce14d8b6
Gecko: dbf49343e889
Version: 32.0 (2.0)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 4

[Andrew Overholt [:overholt]]

This seems like a lockscreen regression (despite it perhaps not being a regression when taking NFC into account).  Greg, is this related to bug 1081132?

Triagers discussed this and think it should block.

Comment 5

[Greg Weng [:snowmantw][:gweng][:λ]]

I think the Bug 1081132 should fix it, not result it. But I would do some bisect to make sure what's the first broken patch.

Comment 6

[Greg Weng [:snowmantw][:gweng][:λ]]

Wait a minute: this is not a regression and we didn't handle this case since v2.0 according to Comment 4. We need to take a look about the root cause.

Comment 7

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch v2.1

Alive: another orientation series bug... And I can't submit the master version since on current master NFC is broken. I would submit the patch after the master is back.

Comment 8

[Greg Weng [:snowmantw][:gweng][:λ]]

The 2.1 patch encountered serious CI issue:

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=16488d64eb34

Some of the failures are intermittent (Gu and Gip). However, the Gij now is permanent red at #3 and #4 job, and it's also red at another test patch's test result:

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=5bbd7556a22d

So I think my patch break nothing, and can submit the v2.1 approval.

Comment 9

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

Alive: almost the same patch except it's for v2.2 (master). And I need to submit v2.0 patch which may be very different...

Comment 10

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8519706 [details] [review]
Patch v2.1

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Orientation API design issue + Gaia didn't capture this case since 2.0
[User impact] if declined: Bug still open
[Testing completed]: Gaia-Try with intermittent and other irrelevant failures. See above comment.
[Risk to taking this patch] (and alternatives if risky): No obvious risk. 
[String changes made]: No

Comment 11

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch v2.0

Basically is copying the previous versions to this one.
The difference is v2.0 need no resizing which is necessary for v2.1 and v2.2 to avoid the splitting window issue, as the video shows.

Comment 12

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8519755 [details] [review]
Patch v2.0

r+ but I want to make sure the resize is a must-have.

Comment 13

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8519728 [details] [review]
Patch

Please request review again for system-resize

Comment 14

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8519728 [details] [review]
Patch

Update the patch as we discussed, so set the flag again.

Comment 15

[Greg Weng [:snowmantw][:gweng][:λ]]

The v2.1 patch is updated, too.

Comment 16

[bhavana bajaj [:bajaj]]

waiting for master landing here before uplifting this on 2.1 branch.

Comment 17

[Greg Weng [:snowmantw][:gweng][:λ]]

Master patch seems good on Gaia-Try:

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=85750260e054

Comment 18

[Greg Weng [:snowmantw][:gweng][:λ]]

The 2.0 patch only encountered one permanent failure which occurs on other PR like this:

https://tbpl.mozilla.org/?tree=Gaia-Try&rev=8ef3eefb56d4

My PR result is here:

https://tbpl.mozilla.org/?tree=Gaia-Try&rev=bc326dde5399

So I'll submit approval request.

Comment 19

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8519755 [details] [review]
Patch v2.0

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Orientation API design issue + Gaia didn't capture this case since 2.0
[User impact] if declined: Bug still open
[Testing completed]: Gaia-Try with intermittent and other irrelevant failures. See above comment.
[Risk to taking this patch] (and alternatives if risky): No obvious risk. 
[String changes made]: No

Comment 20

[Greg Weng [:snowmantw][:gweng][:λ]]

Updated master patch is good on Gaia-Try with several re-runs:

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=412c16cfed60

So I would land it.

Comment 21

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/c0ec35e3eb1e0a960425244e9465b0b893dece92

Comment 22

[Greg Weng [:snowmantw][:gweng][:λ]]

Updated v2.1 patch status: intermittent Gij and irrelevant Gip failures ("Window.getComputedStyle is not an object" in a11y Gip test) only. Would land it.

Comment 23

[Greg Weng [:snowmantw][:gweng][:λ]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/569a299ca446f714cd98d5881cc058fd6f6e257b

Comment 24

[bhavana bajaj [:bajaj]]

Comment on attachment 8519755 [details] [review]
Patch v2.0

Requesting QA verification once this lands.

Comment 25

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/1f7b979b97375c4a4fcbb94ffe640768e2a0f5b8

Comment 26

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.0, 2.1 and 2.2.

Result: The lockscreen does not rotate.

Device: Flame 2.0 (319mb, KK, Shallow Flash)
BuildID: 20141114040205
Gaia: 1e300eac2e56d98ad51d414766d031db7d33221f
Gecko: bbb68df450c2
Version: 36.0a1 (2.2) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Device: Flame 2.1 (319mb, KK, Shallow Flash)
BuildID: 20141114001204
Gaia: af6533781356acc62b0f40c9e040aa5b47d3b709
Gecko: 551326425826
Version: 34.0 (2.1)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.2 (319mb, KK, Full Flash)
BuildID: 20141114040205
Gaia: 1e300eac2e56d98ad51d414766d031db7d33221f
Gecko: bbb68df450c2
Version: 36.0a1 (2.2) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0
===============================================================

Alison, I verified this issue on 2.2 with full flash because shallow flash has an issue as mentioned in bug 1094527. Is it okay to go ahead and mark this bug as verified for all branches, including 2.2?

Thanks!

Comment 27

[Alison Shiue]

(In reply to Yeojin Chung [:YeojinC] from comment #26)
> This issue is verified fixed on Flame 2.0, 2.1 and 2.2.
> 
> Result: The lockscreen does not rotate.
> 
> Device: Flame 2.0 (319mb, KK, Shallow Flash)
> BuildID: 20141114040205
> Gaia: 1e300eac2e56d98ad51d414766d031db7d33221f
> Gecko: bbb68df450c2
> Version: 36.0a1 (2.2) 
> Firmware Version: v188-1
> User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0
> 
> Device: Flame 2.1 (319mb, KK, Shallow Flash)
> BuildID: 20141114001204
> Gaia: af6533781356acc62b0f40c9e040aa5b47d3b709
> Gecko: 551326425826
> Version: 34.0 (2.1)
> Firmware: V188-1
> User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
> 
> Device: Flame 2.2 (319mb, KK, Full Flash)
> BuildID: 20141114040205
> Gaia: 1e300eac2e56d98ad51d414766d031db7d33221f
> Gecko: bbb68df450c2
> Version: 36.0a1 (2.2) 
> Firmware Version: v188-1
> User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0
> ===============================================================
> 
> Alison, I verified this issue on 2.2 with full flash because shallow flash
> has an issue as mentioned in bug 1094527. Is it okay to go ahead and mark
> this bug as verified for all branches, including 2.2?
> 
> Thanks!

Yes, please mark this bug as verified. Thanks!