Closed Bug 1089582 Opened 5 years ago Closed 5 years ago

Don't do a major GC when the store buffer is full

Categories

(Core :: JavaScript: GC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

At the moment we trigger a full GC when the storebuffer is full when all we need is a minor GC.

This is a patch to allow a minor GC to be requested separately from a major GC.

This situation does occur on the octane benchmark, but this patch doesn't noticeably improve our results.
Attachment #8511919 - Attachment is patch: true
Attachment #8511919 - Flags: review?(terrence)
Comment on attachment 8511919 [details] [diff] [review]
minor-gc-on-full-storebuffer

Review of attachment 8511919 [details] [diff] [review]:
-----------------------------------------------------------------

Gah, good catch! I thought I had fixed that ages ago.
Attachment #8511919 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/86d5e68991b2
Assignee: nobody → jcoppeard
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.