1089589 - [Calendar]Existing remind me option can be set again when adding new event.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[swathiks115]

STR

1.Open calendar app
2.Tap [+] icon.
3. Select an [Remind me] option.
4. Using 'None' in remind me,select same [Remind me] option as same as that in step 3 and repeat to make same options.

Comment 1

[swathiks115]

With the above STR, same event is notified many number of times. Example: If "At time of event" is added thrice in Remind me. Three notification occurs for the same event.

Comment 2

[Miller Medeiros [:millermedeiros]]

Harly, should we change this behavior?

Comment 3

[Harly Hsu[:harly]]

Hi Miller, this is indeed a strange behavior, and I think we have two ways to deal with this:
1. Do not let the user set same remind time, if user selects "5 minutes before" in the first reminder, the next reminder will not have "5 minutes before" option in the value selector.
2. Let the user set same remind time, and when user save the event, it will only save one reminder and also display only one notification.

Let me know which one you think is more feasible. Thanks

Comment 4

[swathiks115]

One more issue is, when we change any Remind me to "None", without selecting OK button it will go back to add event screen. I think only when user selects 'ok' button it should go back to previous(Add event) screen. Is this an issue or expected behavior?

Comment 5

[Harly Hsu[:harly]]

I have tried on my Flame to add a new event, and change the "5 minutes before" to "None", it will not go back to add event screen unless I tap OK. Therefore, I am not sure what the issue is, could you be more specific?

Comment 6

[Miller Medeiros [:millermedeiros]]

(In reply to Harly Hsu from comment #3)
> 2. Let the user set same remind time, and when user save the event, it will
> only save one reminder and also display only one notification.

way easier to do this way, otherwise we need to rebuild all the select menus every time the user changes the values and we might get into weird edge cases.

Comment 7

[swathiks115]

(In reply to Harly Hsu from comment #5)
> I have tried on my Flame to add a new event, and change the "5 minutes
> before" to "None", it will not go back to add event screen unless I tap OK.
> Therefore, I am not sure what the issue is, could you be more specific?

STR 
1. open calendar.
2. select + icon
3. in remind me change "5 minutes before" to "none"

when none is selected it will go back to previous screen(add event)
but if you select any thing other than "none" it will not go to previous screen unless you tap OK button.

Thanks.

Comment 8

[Harly Hsu[:harly]]

(In reply to swathiks115 from comment #7)
> (In reply to Harly Hsu from comment #5)
> > I have tried on my Flame to add a new event, and change the "5 minutes
> > before" to "None", it will not go back to add event screen unless I tap OK.
> > Therefore, I am not sure what the issue is, could you be more specific?
> 
> STR 
> 1. open calendar.
> 2. select + icon
> 3. in remind me change "5 minutes before" to "none"
> 
> when none is selected it will go back to previous screen(add event)
> but if you select any thing other than "none" it will not go to previous
> screen unless you tap OK button.
> 
> Thanks.

I see what you mean. Yes, this is a bug, is there a separate bug addressing this issue?
If not, I am happy to open a new bug for this.
Thanks

Comment 9

[Harly Hsu[:harly]]

(In reply to Miller Medeiros [:millermedeiros] from comment #6)
> (In reply to Harly Hsu from comment #3)
> > 2. Let the user set same remind time, and when user save the event, it will
> > only save one reminder and also display only one notification.
> 
> way easier to do this way, otherwise we need to rebuild all the select menus
> every time the user changes the values and we might get into weird edge
> cases.

Yeah, that's what I thought as well. Let's make the modification based on proposal 2 when someone has time to take on this bug.

Comment 10

[swathiks115]

(In reply to Harly Hsu from comment #8)
> (In reply to swathiks115 from comment #7)
> > (In reply to Harly Hsu from comment #5)
> > > I have tried on my Flame to add a new event, and change the "5 minutes
> > > before" to "None", it will not go back to add event screen unless I tap OK.
> > > Therefore, I am not sure what the issue is, could you be more specific?
> > 
> > STR 
> > 1. open calendar.
> > 2. select + icon
> > 3. in remind me change "5 minutes before" to "none"
> > 
> > when none is selected it will go back to previous screen(add event)
> > but if you select any thing other than "none" it will not go to previous
> > screen unless you tap OK button.
> > 
> > Thanks.
> 
> I see what you mean. Yes, this is a bug, is there a separate bug addressing
> this issue?
> If not, I am happy to open a new bug for this.
> Thanks

I think there is no bug addressing this issue.

Thanks.

Comment 11

[Miller Medeiros [:millermedeiros]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25884

Comment 12

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8518176 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25884

This is great. I love the marionette tests you added.

Comment 13

[Gareth Aye [:gaye] (back from PTO)]

(Just one nit on GH)

Comment 14

[Miller Medeiros [:millermedeiros]]

landed on master: https://github.com/mozilla-b2g/gaia/commit/768d981e2513043a148dd55221069808221cf277

Comment 15

[Edward Chen[:edchen]]

[Environment]
Gaia-Rev        5ae28ff11b982e2bd7d1aa097cda131536952bdc
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/a926116946f8
Build-ID        20141111160205
Version         36.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  39
FW-Date         Thu Oct 16 18:19:14 CST 2014
Bootloader      L1TC00011880

[Result]
PASS

Comment 16

[Shally Li（leave from Mozilla）]

Per comment 15, set 'status-b2g-v2.2:' as verified.