1089632 - Setter with a RestParameter should be a SyntaxError

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

Noticed by Waldo in bug 911142, comment 8.

The grammar starts out like this:

    MethodDefinition :
        set PropertyName ( PropertySetParameterList ) { FunctionBody }

    PropertySetParameterList :
        FormalParameter

and it turns out FormalParameter and FunctionRestParameter are two disjoint bits of syntax.

https://people.mozilla.org/~jorendorff/es6-draft.html#sec-method-definitions

Comment 1

[Tom S [:evilpie]]

Doesn't that actually mean there has to be one single parameter and nothing else?

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Throw SyntaxError if RestParameter is used in setter.

Green on try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4a93d228b7e

Comment 3

[Jeff Walden [:Waldo]]

Comment on attachment 8548192 [details] [diff] [review]
Throw SyntaxError if RestParameter is used in setter.

Review of attachment 8548192 [details] [diff] [review]:
-----------------------------------------------------------------

Mm.  This at least I can polish off quickly.  Sorry I'm taking so long on some of your other patches.  :-(  Promise to get to them soon!

Comment 4

[Tooru Fujisawa [:arai]]

Thank you for reviewing :D

https://hg.mozilla.org/integration/mozilla-inbound/rev/6a59a5ee91b4

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6a59a5ee91b4

Comment 6

[Tooru Fujisawa [:arai]]

Updated following documents:
  https://developer.mozilla.org/en-US/Firefox/Releases/38
  https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/set

Comment 7

[Florian Scholz (Open Web Docs)]

Thanks :arai!

Comment 8

[Kohei Yoshino]

https://developer.mozilla.org/en-US/Firefox/Releases/38/Site_Compatibility