1089694 - Profile manager does not remember last used profile

Status: VERIFIED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Alice0775 White]

[Tracking Requested - why for this release]:

Steps To Reproduce;
1. run 'firefox.exe -P' (without quotation marks)

2. Choose a profile , un-check all checboxes
3. Click [Start Nightly]

4. Exit browser

5. run 'firefox.exe -P' again

Actual Results:
Profile manager does not remember last used profile

Expected results:
Last used profile should be selected

Comment 1

[Dave Townsend [:mossop]]

Caused by bug 1024110 maybe?

Comment 2

[Benjamin Smedberg]

Alice, which version/channel are you testing with?

Comment 3

[Alice0775 White]

Regression window(fx)
Good:
https://hg.mozilla.org/integration/fx-team/rev/805c0b62d318
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0 ID:20141024014314
Bad:
https://hg.mozilla.org/integration/fx-team/rev/1416eeab79a2
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0 ID:20141024015813
Pushlog:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=805c0b62d318&tochange=1416eeab79a2
Regressed by:
1416eeab79a2	Panos Astithas — Bug 1024110 - Change Aurora's default profile behavior to use channel-specific profiles. r=bsmedberg f=gavin,markh

Comment 4

[Alice0775 White]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #2)
> Alice, which version/channel are you testing with?

nightly and default  
(default is tinderbox build)

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Dave Townsend [:mossop] from comment #1)
> Caused by bug 1024110 maybe?

Yes, I know how to fix this. Taking.

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: When selecting a profile in the Profile Manager, mark it with Default=1

With the introduction of profileService.defaultProfile I missed a spot where the equivalence between selectedProfile and defaultProfile used to be implicit, but now has to be explicit.

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/df5af1c51264

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/df5af1c51264

Comment 9

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8512046 [details] [diff] [review]
When selecting a profile in the Profile Manager, mark it with Default=1

Approval Request Comment
[Feature/regressing bug #]: bug 1024110
[User impact if declined]: using the profile manager to select a profile and disabling "Use the selected profile w/o asking at startup" will cause the selected profile to be forgotten the next time the user enters the profile manager
[Describe test coverage new/current, TBPL]: m-c, gum
[Risks and why]: trivial patch, virtually zero risk
[String/UUID change made/needed]: none

Comment 10

[Camelia Badau [:cbadau], Desktop Test Engineering]

Verified fixed with latest gum build (buildID: 20141104133445).

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/19e3dd4d7365

Comment 12

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

No longer an issue with Firefox 35 beta 4 (BuildID=20141216120925) on Windows 7 x64. The latest used profile is correctly remembered.