Closed
Bug 1089758
Opened 10 years ago
Closed 10 years ago
EmitElemOpBase's automagical JSOP_SWAP is too magical
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: jorendorff, Assigned: jorendorff)
Details
Attachments
(1 file)
|
3.10 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
"WTF is going on here?" --every frontend reviewer ever, most recently Jeff in bug 918828 comment 48.
Time to fix it.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8512183 -
Flags: review?(jwalden+bmo)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8512183 [details] [diff] [review]
EmitElemOpBase's automagical JSOP_SWAP is too magical
Review of attachment 8512183 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/frontend/BytecodeEmitter.cpp
@@ -2439,5 @@
> -
> - if (op == JSOP_CALLELEM) {
> - if (Emit1(cx, bce, JSOP_SWAP) < 0)
> - return false;
> - }
Ye gods.
Attachment #8512183 -
Flags: review?(jwalden+bmo) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
|
|
Assignee | |
Comment 4•10 years ago
|
||
|
||
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•