1089812 - Implement updated In-content pref secondary dialogs

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Michael Maslaney [:mmaslaney] ([e-mail])]

Implement the updated In-content pref secondary dialogs.

Mocks:
http://people.mozilla.org/~mmaslaney/incontent/Preferences-dialog-types.png

Spec:
http://people.mozilla.org/~mmaslaney/incontent/Preferences-dialog-types-spec.png

Comment 2

[Tim Nguyen :ntim]

Attachment: Patch

This patch :
- Updates the dialog styling
- Updates the tree styling (both to match the dialog spec)
- Note that I put the tree styling inside the shared file, since it's gonna be used for other in content pages

Comment 3

[Tim Nguyen :ntim]

Attachment: Patch v2

Addressed feedback by mmaslaney.

Comment 4

[Tim Nguyen :ntim]

Attachment: Patch v3

Removed the tree and listbox changes. Moved them to bug 1087618

Comment 5

[Tim Nguyen :ntim]

Comment on attachment 8520832 [details] [diff] [review]
Patch v3

Review of attachment 8520832 [details] [diff] [review]:
-----------------------------------------------------------------

Need to rebase this on top of bug 1062127

Comment 6

[Tim Nguyen :ntim]

Attachment: Patch v4

Rebased.

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 8521389 [details] [diff] [review]
Patch v4

>-}
>+}
>\ No newline at end of file

Please fix this throughout the patch.

Comment 8

[Tim Nguyen :ntim]

Attachment: Patch v5

Restored newlines at end of files

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8ce7d46f1f99

Comment 10

[Camelia Badau [:cbadau], Desktop Test Engineering]

Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using Firefox 36 Beta 3 (buildID: 20150122214638).