Closed Bug 1089812 Opened 7 years ago Closed 7 years ago

Implement updated In-content pref secondary dialogs

Categories

(Firefox :: Preferences, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 36
Iteration:
36.3
Tracking Status
firefox36 --- verified

People

(Reporter: mmaslaney, Assigned: ntim)

References

Details

Attachments

(1 file, 4 obsolete files)

Flags: firefox-backlog+
Duplicate of this bug: 1089814
Attached patch Patch (obsolete) — Splinter Review
This patch :
- Updates the dialog styling
- Updates the tree styling (both to match the dialog spec)
- Note that I put the tree styling inside the shared file, since it's gonna be used for other in content pages
Assignee: nobody → ntim007
Status: NEW → ASSIGNED
Attachment #8520712 - Flags: review?(jaws)
Attached patch Patch v2 (obsolete) — Splinter Review
Addressed feedback by mmaslaney.
Attachment #8520712 - Attachment is obsolete: true
Attachment #8520712 - Flags: review?(jaws)
Attachment #8520742 - Flags: review?(jaws)
Attached patch Patch v3 (obsolete) — Splinter Review
Removed the tree and listbox changes. Moved them to bug 1087618
Attachment #8520742 - Attachment is obsolete: true
Attachment #8520742 - Flags: review?(jaws)
Attachment #8520832 - Flags: review?(jaws)
Comment on attachment 8520832 [details] [diff] [review]
Patch v3

Review of attachment 8520832 [details] [diff] [review]:
-----------------------------------------------------------------

Need to rebase this on top of bug 1062127
Attachment #8520832 - Flags: review?(jaws)
Attached patch Patch v4 (obsolete) — Splinter Review
Rebased.
Attachment #8520832 - Attachment is obsolete: true
Attachment #8521389 - Flags: review?(dao)
Comment on attachment 8521389 [details] [diff] [review]
Patch v4

>-}
>+}
>\ No newline at end of file

Please fix this throughout the patch.
Attachment #8521389 - Flags: review?(dao)
Attached patch Patch v5Splinter Review
Restored newlines at end of files
Attachment #8521389 - Attachment is obsolete: true
Attachment #8521484 - Flags: review?(dao)
Attachment #8521484 - Flags: review?(dao) → review+
Whiteboard: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8ce7d46f1f99
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: checkin-needed
Target Milestone: --- → Firefox 36
Iteration: --- → 36.3
Flags: qe-verify?
Flags: qe-verify? → qe-verify+
QA Contact: camelia.badau
Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using Firefox 36 Beta 3 (buildID: 20150122214638).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.